Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658632 > unrolled thread
| Started by | Johan Hovold <johan@kernel.org> |
|---|---|
| First post | 2017-06-06 13:10 +0200 |
| Last post | 2017-06-07 12:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/9] tty: drop broken alt-speed handling Johan Hovold <johan@kernel.org> - 2017-06-06 13:10 +0200
Re: [PATCH 0/9] tty: drop broken alt-speed handling Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-06-06 13:40 +0200
Re: [PATCH 0/9] tty: drop broken alt-speed handling Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-07 12:00 +0200
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2017-06-06 13:10 +0200 |
| Subject | [PATCH 0/9] tty: drop broken alt-speed handling |
| Message-ID | <tPknn-7Bq-5@gated-at.bofh.it> |
Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated
since v2.1.69 and has been broken for all tty drivers but serial-core
since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting
speed via SPD_*") without anyone noticing (for four years).
Instead of reverting the offending commit, lets get rid of this legacy
code while adding back a warning about the SPD flags being deprecated to
the drivers that once implemented it. Note that drivers implementing
SPD_CUST will continue to support using a custom divisor.
Also note that serial-core did not rely on the TTY layer for SPD
handling and continues to support it while warning about deprecation
(since 2003 at least).
Greg, I suggest you take it all trough the TTY tree even if merging
through multiple trees and applying the final patch once everything is
upstream would be an option. Also the irda clean up does not depend on
the rest of series as the code implementing SPD handling was ifdefed
out.
Johan
Johan Hovold (9):
serial: rate limit custom-speed deprecation notice
USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic
USB: serial: ftdi_sio: remove broken alt-speed handling
tty: simserial: drop unused alt_speed handling
tty: amiserial: drop broken alt-speed support
tty: cyclades: drop broken alt-speed support
tty: rocket: drop broken alt-speed support
tty: ircomm: remove dead and broken ioctl code
tty: drop unused alt_speed from tty_struct
arch/ia64/hp/sim/simserial.c | 13 -----
drivers/tty/amiserial.c | 23 ++------
drivers/tty/cyclades.c | 21 ++++----
drivers/tty/rocket.c | 27 +++-------
drivers/tty/serial/serial_core.c | 5 +-
drivers/usb/serial/ftdi_sio.c | 67 +++++------------------
include/linux/tty.h | 1 -
net/irda/ircomm/ircomm_tty_ioctl.c | 107 +------------------------------------
8 files changed, 34 insertions(+), 230 deletions(-)
--
2.13.0
[toc] | [next] | [standalone]
| From | Alan Cox <gnomes@lxorguk.ukuu.org.uk> |
|---|---|
| Date | 2017-06-06 13:40 +0200 |
| Message-ID | <tPl06-8cX-21@gated-at.bofh.it> |
| In reply to | #1658632 |
On Tue, 6 Jun 2017 12:54:32 +0200
Johan Hovold <johan@kernel.org> wrote:
> Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated
> since v2.1.69 and has been broken for all tty drivers but serial-core
> since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting
> speed via SPD_*") without anyone noticing (for four years).
We have the ability to set the speed directly via termios so I doubt
anyone is using the remaining hacks either but I guess someone may. All
looks good to me.
Reviewed-by: Alan Cox <alan@linux.intel.com>
Alan
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-06-07 12:00 +0200 |
| Message-ID | <tPFUS-4WH-31@gated-at.bofh.it> |
| In reply to | #1658632 |
On Tue, Jun 6, 2017 at 1:54 PM, Johan Hovold <johan@kernel.org> wrote:
> Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated
> since v2.1.69 and has been broken for all tty drivers but serial-core
> since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting
> speed via SPD_*") without anyone noticing (for four years).
>
> Instead of reverting the offending commit, lets get rid of this legacy
> code while adding back a warning about the SPD flags being deprecated to
> the drivers that once implemented it. Note that drivers implementing
> SPD_CUST will continue to support using a custom divisor.
>
> Also note that serial-core did not rely on the TTY layer for SPD
> handling and continues to support it while warning about deprecation
> (since 2003 at least).
>
> Greg, I suggest you take it all trough the TTY tree even if merging
> through multiple trees and applying the final patch once everything is
> upstream would be an option. Also the irda clean up does not depend on
> the rest of series as the code implementing SPD handling was ifdefed
> out.
What a nice clean up!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Johan
>
>
> Johan Hovold (9):
> serial: rate limit custom-speed deprecation notice
> USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic
> USB: serial: ftdi_sio: remove broken alt-speed handling
> tty: simserial: drop unused alt_speed handling
> tty: amiserial: drop broken alt-speed support
> tty: cyclades: drop broken alt-speed support
> tty: rocket: drop broken alt-speed support
> tty: ircomm: remove dead and broken ioctl code
> tty: drop unused alt_speed from tty_struct
>
> arch/ia64/hp/sim/simserial.c | 13 -----
> drivers/tty/amiserial.c | 23 ++------
> drivers/tty/cyclades.c | 21 ++++----
> drivers/tty/rocket.c | 27 +++-------
> drivers/tty/serial/serial_core.c | 5 +-
> drivers/usb/serial/ftdi_sio.c | 67 +++++------------------
> include/linux/tty.h | 1 -
> net/irda/ircomm/ircomm_tty_ioctl.c | 107 +------------------------------------
> 8 files changed, 34 insertions(+), 230 deletions(-)
>
> --
> 2.13.0
>
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web