Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658599 > unrolled thread

[PATCH] watchdog: davinci: Add missing clk_disable_unprepare().

Back to article view | Back to linux.kernel

Contents

  [PATCH] watchdog: davinci: Add missing clk_disable_unprepare(). Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-06 12:40 +0200

#1658599 — [PATCH] watchdog: davinci: Add missing clk_disable_unprepare().

davinci_wdt_probe() can fail here and we must disable clock.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/watchdog/davinci_wdt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
index 1ba9ead..2f46487 100644
--- a/drivers/watchdog/davinci_wdt.c
+++ b/drivers/watchdog/davinci_wdt.c
@@ -202,8 +202,10 @@ static int davinci_wdt_probe(struct platform_device *pdev)
 		return PTR_ERR(davinci_wdt->base);
 
 	ret = watchdog_register_device(wdd);
-	if (ret < 0)
+	if (ret < 0) {
+		clk_disable_unprepare(davinci_wdt->clk);
 		dev_err(dev, "cannot register watchdog device\n");
+	}
 
 	return ret;
 }
-- 
1.9.1

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web