Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1656698 > unrolled thread

[PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if not taken

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if  not taken "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-06-03 05:40 +0200
    [tip:smp/hotplug] perf/core: Don't release cred_guard_mutex if not  taken tip-bot for Alexander Levin <tipbot@zytor.com> - 2017-06-03 09:40 +0200
    Re: [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex  if not taken "bigeasy@linutronix.de" <bigeasy@linutronix.de> - 2017-06-06 11:10 +0200

#1656698 — [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if not taken

From: Alexander Levin <alexander.levin@verizon.com>

If we failed to acquire task's cred_guard_mutex we shouldn't proceed
to release it in the error path.

Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order")
Signed-off-by: Alexander Levin <alexander.levin@verizon.com>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 8d6acaeeea17..8e8323c6036b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9878,7 +9878,7 @@ SYSCALL_DEFINE5(perf_event_open,
 	if (task) {
 		err = mutex_lock_interruptible(&task->signal->cred_guard_mutex);
 		if (err)
-			goto err_cred;
+			goto err_task;
 
 		/*
 		 * Reuse ptrace permission checks for now.
-- 
2.11.0

[toc] | [next] | [standalone]

#1656745 — [tip:smp/hotplug] perf/core: Don't release cred_guard_mutex if not taken

Commit-ID:  e5aeee51f6b4fb22e851105ee6d8ad211c40a214
Gitweb:     http://git.kernel.org/tip/e5aeee51f6b4fb22e851105ee6d8ad211c40a214
Author:     Alexander Levin <alexander.levin@verizon.com>
AuthorDate: Sat, 3 Jun 2017 03:39:13 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 3 Jun 2017 09:28:45 +0200

perf/core: Don't release cred_guard_mutex if not taken

If we failed to acquire task's cred_guard_mutex we shouldn't proceed
to release it in the error path.

Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order")
Signed-off-by: Alexander Levin <alexander.levin@verizon.com>
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
Cc: mathieu.desnoyers@efficios.com
Cc: mhiramat@kernel.org
Cc: paulmck@linux.vnet.ibm.com
Cc: bigeasy@linutronix.de
Link: http://lkml.kernel.org/r/20170603033903.12056-1-alexander.levin@verizon.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index b97cda4..1f1b8cd 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9878,7 +9878,7 @@ SYSCALL_DEFINE5(perf_event_open,
 	if (task) {
 		err = mutex_lock_interruptible(&task->signal->cred_guard_mutex);
 		if (err)
-			goto err_cred;
+			goto err_task;
 
 		/*
 		 * Reuse ptrace permission checks for now.

[toc] | [prev] | [next] | [standalone]

#1658506 — Re: [PATCH] perf/tracing/cpuhotplug: don't release cred_guard_mutex if not taken

On 2017-06-03 03:39:13 [+0000], Levin, Alexander (Sasha Levin) wrote:
> From: Alexander Levin <alexander.levin@verizon.com>
> 
> If we failed to acquire task's cred_guard_mutex we shouldn't proceed
> to release it in the error path.
> 
> Fixes: a63fbed776c ("perf/tracing/cpuhotplug: Fix locking order")
> Signed-off-by: Alexander Levin <alexander.levin@verizon.com>

Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web