Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657640 > unrolled thread
| Started by | Steve Twiss <stwiss.opensource@diasemi.com> |
|---|---|
| First post | 2017-06-05 16:50 +0200 |
| Last post | 2017-06-06 09:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model Steve Twiss <stwiss.opensource@diasemi.com> - 2017-06-05 16:50 +0200
Re: [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model Lee Jones <lee.jones@linaro.org> - 2017-06-06 09:20 +0200
| From | Steve Twiss <stwiss.opensource@diasemi.com> |
|---|---|
| Date | 2017-06-05 16:50 +0200 |
| Subject | [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model |
| Message-ID | <tP1uq-499-7@gated-at.bofh.it> |
From: Steve Twiss <stwiss.opensource@diasemi.com>
Remove the register DA9062AA_BBAT_CONT (0x0C5) from the DA9061 chip model
regmap access ranges. This applies to both da9061_aa_readable_ranges[]
and da9061_aa_writeable_ranges[].
This change is to correct the DA9061 chip model and align it with the
latest DA9061 Datasheet.
This register previously appeared in the DA9061 Datasheet, Revision 3.2,
01-Mar-2016 and has been removed from later DA9061 datasheet from Dialog,
Revision 3.3, 04-Apr-2017.
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
---
Hi Lee,
This is a fix to remove DA9062AA_BBAT_CONT register from the DA9061
regmap read/write access tables. It only applies to the DA9061 chip,
and does not affect the DA9062.
No existing kernel code tries to access this register, so the change is
just a formality to correct the DA9061 chip model and align it with the
DA9061 Datasheet.
This patch applies against linux-next and v4.12-rc3
Regards,
Steve Twiss, Dialog Semiconductor
drivers/mfd/da9062-core.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
index 7f5e8be..fe18115 100644
--- a/drivers/mfd/da9062-core.c
+++ b/drivers/mfd/da9062-core.c
@@ -429,9 +429,6 @@ static int da9062_get_device_type(struct da9062 *chip)
.range_min = DA9062AA_VLDO1_B,
.range_max = DA9062AA_VLDO4_B,
}, {
- .range_min = DA9062AA_BBAT_CONT,
- .range_max = DA9062AA_BBAT_CONT,
- }, {
.range_min = DA9062AA_INTERFACE,
.range_max = DA9062AA_CONFIG_E,
}, {
@@ -514,9 +511,6 @@ static int da9062_get_device_type(struct da9062 *chip)
.range_min = DA9062AA_VLDO1_B,
.range_max = DA9062AA_VLDO4_B,
}, {
- .range_min = DA9062AA_BBAT_CONT,
- .range_max = DA9062AA_BBAT_CONT,
- }, {
.range_min = DA9062AA_GP_ID_0,
.range_max = DA9062AA_GP_ID_19,
},
--
end-of-patch for PATCH V1
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-06-06 09:20 +0200 |
| Subject | Re: [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model |
| Message-ID | <tPgWu-5BA-17@gated-at.bofh.it> |
| In reply to | #1657640 |
On Mon, 05 Jun 2017, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
>
> Remove the register DA9062AA_BBAT_CONT (0x0C5) from the DA9061 chip model
> regmap access ranges. This applies to both da9061_aa_readable_ranges[]
> and da9061_aa_writeable_ranges[].
>
> This change is to correct the DA9061 chip model and align it with the
> latest DA9061 Datasheet.
>
> This register previously appeared in the DA9061 Datasheet, Revision 3.2,
> 01-Mar-2016 and has been removed from later DA9061 datasheet from Dialog,
> Revision 3.3, 04-Apr-2017.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
> ---
>
> Hi Lee,
>
> This is a fix to remove DA9062AA_BBAT_CONT register from the DA9061
> regmap read/write access tables. It only applies to the DA9061 chip,
> and does not affect the DA9062.
>
> No existing kernel code tries to access this register, so the change is
> just a formality to correct the DA9061 chip model and align it with the
> DA9061 Datasheet.
>
> This patch applies against linux-next and v4.12-rc3
>
> Regards,
> Steve Twiss, Dialog Semiconductor
>
>
> drivers/mfd/da9062-core.c | 6 ------
> 1 file changed, 6 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index 7f5e8be..fe18115 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -429,9 +429,6 @@ static int da9062_get_device_type(struct da9062 *chip)
> .range_min = DA9062AA_VLDO1_B,
> .range_max = DA9062AA_VLDO4_B,
> }, {
> - .range_min = DA9062AA_BBAT_CONT,
> - .range_max = DA9062AA_BBAT_CONT,
> - }, {
> .range_min = DA9062AA_INTERFACE,
> .range_max = DA9062AA_CONFIG_E,
> }, {
> @@ -514,9 +511,6 @@ static int da9062_get_device_type(struct da9062 *chip)
> .range_min = DA9062AA_VLDO1_B,
> .range_max = DA9062AA_VLDO4_B,
> }, {
> - .range_min = DA9062AA_BBAT_CONT,
> - .range_max = DA9062AA_BBAT_CONT,
> - }, {
> .range_min = DA9062AA_GP_ID_0,
> .range_max = DA9062AA_GP_ID_19,
> },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web