Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1660777 > unrolled thread

[PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE

Started byYisheng Xie <xieyisheng1@huawei.com>
First post2017-06-08 08:20 +0200
Last post2017-06-08 18:20 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Yisheng Xie <xieyisheng1@huawei.com> - 2017-06-08 08:20 +0200
    Re: [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-06-08 18:10 +0200
    Re: [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-08 18:20 +0200

#1660777 — [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE

FromYisheng Xie <xieyisheng1@huawei.com>
Date2017-06-08 08:20 +0200
Subject[PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE
Message-ID<tPYXv-yI-3@gated-at.bofh.it>
When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
fail and stop after uncompressed:

   Starting kernel ...

   Uart base = 0x20001000
   watchdog reg = 0x20013000
   dtb addr = 0x80840308
   Uncompressing Linux... done, booting the kernel.

For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
   http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16

So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
this bug.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 4c1a35f..c0fcab6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1416,6 +1416,7 @@ choice
 	config VMSPLIT_3G
 		bool "3G/1G user/kernel split"
 	config VMSPLIT_3G_OPT
+		depends on !ARM_LPAE
 		bool "3G/1G user/kernel split (for full 1G low memory)"
 	config VMSPLIT_2G
 		bool "2G/2G user/kernel split"
-- 
1.7.12.4

[toc] | [next] | [standalone]


#1661420

FromNicolas Pitre <nicolas.pitre@linaro.org>
Date2017-06-08 18:10 +0200
Message-ID<tQ8au-6sQ-5@gated-at.bofh.it>
In reply to#1660777
On Thu, 8 Jun 2017, Yisheng Xie wrote:

> When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
> means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
> fail and stop after uncompressed:
> 
>    Starting kernel ...
> 
>    Uart base = 0x20001000
>    watchdog reg = 0x20013000
>    dtb addr = 0x80840308
>    Uncompressing Linux... done, booting the kernel.
> 
> For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
>    http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16
> 
> So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
> this bug.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>

Acked-by: Nicolas Pitre <nico@linaro.org>


> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 4c1a35f..c0fcab6 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1416,6 +1416,7 @@ choice
>  	config VMSPLIT_3G
>  		bool "3G/1G user/kernel split"
>  	config VMSPLIT_3G_OPT
> +		depends on !ARM_LPAE
>  		bool "3G/1G user/kernel split (for full 1G low memory)"
>  	config VMSPLIT_2G
>  		bool "2G/2G user/kernel split"
> -- 
> 1.7.12.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

[toc] | [prev] | [next] | [standalone]


#1661425

FromRussell King - ARM Linux <linux@armlinux.org.uk>
Date2017-06-08 18:20 +0200
Message-ID<tQ8ka-6xx-7@gated-at.bofh.it>
In reply to#1660777
On Thu, Jun 08, 2017 at 02:05:44PM +0800, Yisheng Xie wrote:
> When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
> means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
> fail and stop after uncompressed:
> 
>    Starting kernel ...
> 
>    Uart base = 0x20001000
>    watchdog reg = 0x20013000
>    dtb addr = 0x80840308
>    Uncompressing Linux... done, booting the kernel.
> 
> For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
>    http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16
> 
> So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
> this bug.

Yes, this is much more preferable.  Please drop it into the patch system,
thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web