Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1660005 > unrolled thread
| Started by | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| First post | 2017-06-07 18:40 +0200 |
| Last post | 2017-06-08 05:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-06-07 18:40 +0200
Re: [PATCH v2 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2017-06-08 05:30 +0200
| From | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| Date | 2017-06-07 18:40 +0200 |
| Subject | Re: [PATCH v2 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices |
| Message-ID | <tPM9X-CA-3@gated-at.bofh.it> |
On Tue, Jun 06, 2017 at 04:17:45PM +0530, Ganapatrao Kulkarni wrote:
> Add code to parse proximity domain in SMMUv3 IORT table to
> set numa node mapping for smmuv3 devices.
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
> drivers/acpi/arm64/iort.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index bba2b59..b4f328f 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -882,6 +882,23 @@ static bool __init arm_smmu_v3_is_coherent(struct acpi_iort_node *node)
> return smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE;
> }
>
> +/*
> + * set numa proximity domain for smmv3 device
> + */
> +static void __init iort_set_proximity(struct acpi_iort_node *node,
> + struct device *dev)
> +{
> + struct acpi_iort_smmu_v3 *smmu;
> +
> + smmu = (struct acpi_iort_smmu_v3 *)node->node_data;
> + if (smmu->flags & ACPI_IORT_SMMU_V3_PXM_VALID) {
> + set_dev_node(dev, acpi_map_pxm_to_node(smmu->pxm));
> + pr_info("SMMUV3[%llx] Mapped to Proximity domain %d\n",
> + smmu->base_address,
> + smmu->pxm);
> + }
> +}
> +
> static int __init arm_smmu_count_resources(struct acpi_iort_node *node)
> {
> struct acpi_iort_smmu *smmu;
> @@ -1002,6 +1019,9 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
> if (!pdev)
> return -ENOMEM;
>
> + if (node->type == ACPI_IORT_NODE_SMMU_V3)
> + iort_set_proximity(node, &pdev->dev);
Nit: while at it you may add an ops hook to set the proximity
(NULL for SMMU v2) and call it if present, it is just to make
the code adding devices more uniform.
Who is queueing these patches ? I am asking to make sure we sort
the ACPICA dependency (there are other IORT/ACPICA patches to consider
too).
Thanks,
Lorenzo
> count = ops->iommu_count_resources(node);
>
> r = kcalloc(count, sizeof(*r), GFP_KERNEL);
> --
> 1.8.1.4
>
[toc] | [next] | [standalone]
| From | Ganapatrao Kulkarni <gpkulkarni@gmail.com> |
|---|---|
| Date | 2017-06-08 05:30 +0200 |
| Subject | Re: [PATCH v2 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices |
| Message-ID | <tPWiZ-7ci-5@gated-at.bofh.it> |
| In reply to | #1660005 |
On Wed, Jun 7, 2017 at 10:08 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> On Tue, Jun 06, 2017 at 04:17:45PM +0530, Ganapatrao Kulkarni wrote:
>> Add code to parse proximity domain in SMMUv3 IORT table to
>> set numa node mapping for smmuv3 devices.
>>
>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>> ---
>> drivers/acpi/arm64/iort.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index bba2b59..b4f328f 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -882,6 +882,23 @@ static bool __init arm_smmu_v3_is_coherent(struct acpi_iort_node *node)
>> return smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE;
>> }
>>
>> +/*
>> + * set numa proximity domain for smmv3 device
>> + */
>> +static void __init iort_set_proximity(struct acpi_iort_node *node,
>> + struct device *dev)
>> +{
>> + struct acpi_iort_smmu_v3 *smmu;
>> +
>> + smmu = (struct acpi_iort_smmu_v3 *)node->node_data;
>> + if (smmu->flags & ACPI_IORT_SMMU_V3_PXM_VALID) {
>> + set_dev_node(dev, acpi_map_pxm_to_node(smmu->pxm));
>> + pr_info("SMMUV3[%llx] Mapped to Proximity domain %d\n",
>> + smmu->base_address,
>> + smmu->pxm);
>> + }
>> +}
>> +
>> static int __init arm_smmu_count_resources(struct acpi_iort_node *node)
>> {
>> struct acpi_iort_smmu *smmu;
>> @@ -1002,6 +1019,9 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
>> if (!pdev)
>> return -ENOMEM;
>>
>> + if (node->type == ACPI_IORT_NODE_SMMU_V3)
>> + iort_set_proximity(node, &pdev->dev);
>
> Nit: while at it you may add an ops hook to set the proximity
> (NULL for SMMU v2) and call it if present, it is just to make
> the code adding devices more uniform.
thanks, will do
>
> Who is queueing these patches ? I am asking to make sure we sort
> the ACPICA dependency (there are other IORT/ACPICA patches to consider
> too).
>
> Thanks,
> Lorenzo
>
>> count = ops->iommu_count_resources(node);
>>
>> r = kcalloc(count, sizeof(*r), GFP_KERNEL);
>> --
>> 1.8.1.4
>>
thanks
Ganapat
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web