Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653126 > unrolled thread

[PATCH 4/5] perf-script-python.txt: Fix wrong code snippets

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets SeongJae Park <sj38.park@gmail.com> - 2017-05-30 13:20 +0200
    Re: [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-08 01:40 +0200
      Re: [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets SeongJae Park <sj38.park@gmail.com> - 2017-06-08 01:50 +0200
    [tip:perf/urgent] perf script python: Fix wrong code snippets in  documentation tip-bot for SeongJae Park <tipbot@zytor.com> - 2017-06-09 01:00 +0200

#1653126 — [PATCH 4/5] perf-script-python.txt: Fix wrong code snippets

This commit fixes wrong code snippets for trace_begin() and trace_end()
function example definition.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/perf/Documentation/perf-script-python.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt
index 44e51351536f..f723ce41268c 100644
--- a/tools/perf/Documentation/perf-script-python.txt
+++ b/tools/perf/Documentation/perf-script-python.txt
@@ -530,7 +530,7 @@ can implement a set of optional functions:
 gives scripts a chance to do setup tasks:
 
 ----
-def trace_begin:
+def trace_begin():
     pass
 ----
 
@@ -539,7 +539,7 @@ def trace_begin:
  as display results:
 
 ----
-def trace_end:
+def trace_end():
     pass
 ----
 
-- 
2.13.0

[toc] | [next] | [standalone]

#1660449

Em Tue, May 30, 2017 at 08:18:26PM +0900, SeongJae Park escreveu:
> This commit fixes wrong code snippets for trace_begin() and trace_end()
> function example definition.

Fixed, and using:

  git log --follow tools/perf/Documentation/perf-script-python.txt

Added the Fixes: tag:

Fixes: cff68e582237 ("perf/scripts: Add perf-trace-python Documentation")

And since you're taking the time to add the Fixes tag (yay, great!)
please also add Cc: entries for the patch author and committer, in that
case:

Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>

I did it this time, using a script I have:

[acme@jouet linux]$ cat ~/bin/fixes 
#!/bin/bash

cset=$1
if [ $# -eq 0 ] ; then
	read cset
fi
git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g'
echo Fixes: `git one $cset`
[acme@jouet linux]$

Just get the cset, in vim, and select it, pressing Shift+V while the
cursor is on top of the cset id and then press : and finally !fixes +
ENTER :)

cff68e582237

- Arnaldo
 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  tools/perf/Documentation/perf-script-python.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt
> index 44e51351536f..f723ce41268c 100644
> --- a/tools/perf/Documentation/perf-script-python.txt
> +++ b/tools/perf/Documentation/perf-script-python.txt
> @@ -530,7 +530,7 @@ can implement a set of optional functions:
>  gives scripts a chance to do setup tasks:
>  
>  ----
> -def trace_begin:
> +def trace_begin():
>      pass
>  ----
>  
> @@ -539,7 +539,7 @@ def trace_begin:
>   as display results:
>  
>  ----
> -def trace_end:
> +def trace_end():
>      pass
>  ----
>  
> -- 
> 2.13.0

[toc] | [prev] | [next] | [standalone]

#1660487

On Thu, Jun 8, 2017 at 8:35 AM, Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
> Em Tue, May 30, 2017 at 08:18:26PM +0900, SeongJae Park escreveu:
>> This commit fixes wrong code snippets for trace_begin() and trace_end()
>> function example definition.
>
> Fixed, and using:
>
>   git log --follow tools/perf/Documentation/perf-script-python.txt
>
> Added the Fixes: tag:
>
> Fixes: cff68e582237 ("perf/scripts: Add perf-trace-python Documentation")
>
> And since you're taking the time to add the Fixes tag (yay, great!)
> please also add Cc: entries for the patch author and committer, in that
> case:

Ok, I will do that from next time.


>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>
> I did it this time, using a script I have:
>
> [acme@jouet linux]$ cat ~/bin/fixes
> #!/bin/bash
>
> cset=$1
> if [ $# -eq 0 ] ; then
>         read cset
> fi
> git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g'
> echo Fixes: `git one $cset`
> [acme@jouet linux]$
>
> Just get the cset, in vim, and select it, pressing Shift+V while the
> cursor is on top of the cset id and then press : and finally !fixes +
> ENTER :)
>
> cff68e582237

So sweet script! :D


Thanks,
SeongJae Park

>
> - Arnaldo
>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>>  tools/perf/Documentation/perf-script-python.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt
>> index 44e51351536f..f723ce41268c 100644
>> --- a/tools/perf/Documentation/perf-script-python.txt
>> +++ b/tools/perf/Documentation/perf-script-python.txt
>> @@ -530,7 +530,7 @@ can implement a set of optional functions:
>>  gives scripts a chance to do setup tasks:
>>
>>  ----
>> -def trace_begin:
>> +def trace_begin():
>>      pass
>>  ----
>>
>> @@ -539,7 +539,7 @@ def trace_begin:
>>   as display results:
>>
>>  ----
>> -def trace_end:
>> +def trace_end():
>>      pass
>>  ----
>>
>> --
>> 2.13.0

[toc] | [prev] | [next] | [standalone]

#1661787 — [tip:perf/urgent] perf script python: Fix wrong code snippets in documentation

Commit-ID:  26ddb8722df865aa67fbe459107d2f3f8e5c6829
Gitweb:     http://git.kernel.org/tip/26ddb8722df865aa67fbe459107d2f3f8e5c6829
Author:     SeongJae Park <sj38.park@gmail.com>
AuthorDate: Tue, 30 May 2017 20:18:26 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 7 Jun 2017 20:27:26 -0300

perf script python: Fix wrong code snippets in documentation

This commit fixes wrong code snippets for trace_begin() and trace_end()
function example definition.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
Fixes: cff68e582237 ("perf/scripts: Add perf-trace-python Documentation")
Link: http://lkml.kernel.org/r/20170530111827.21732-5-sj38.park@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-script-python.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-script-python.txt b/tools/perf/Documentation/perf-script-python.txt
index 087b87c9..bad6e93 100644
--- a/tools/perf/Documentation/perf-script-python.txt
+++ b/tools/perf/Documentation/perf-script-python.txt
@@ -532,7 +532,7 @@ can implement a set of optional functions:
 gives scripts a chance to do setup tasks:
 
 ----
-def trace_begin:
+def trace_begin():
     pass
 ----
 
@@ -541,7 +541,7 @@ def trace_begin:
  as display results:
 
 ----
-def trace_end:
+def trace_end():
     pass
 ----
 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web