Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658585 > unrolled thread

[PATCH] watchdog: davinci: Handle return value of clk_prepare_enable

Back to article view | Back to linux.kernel

Contents

  [PATCH] watchdog: davinci: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-06 12:20 +0200
    Re: [PATCH] watchdog: davinci: Handle return value of  clk_prepare_enable Guenter Roeck <linux@roeck-us.net> - 2017-06-07 22:50 +0200

#1658585 — [PATCH] watchdog: davinci: Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/watchdog/davinci_wdt.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
index 0e731d7..1ba9ead 100644
--- a/drivers/watchdog/davinci_wdt.c
+++ b/drivers/watchdog/davinci_wdt.c
@@ -173,7 +173,11 @@ static int davinci_wdt_probe(struct platform_device *pdev)
 		return PTR_ERR(davinci_wdt->clk);
 	}
 
-	clk_prepare_enable(davinci_wdt->clk);
+	ret = clk_prepare_enable(davinci_wdt->clk);
+	if (ret) {
+		dev_err(&pdev->dev, "failed to prepare clock\n");
+		return ret;
+	}
 
 	platform_set_drvdata(pdev, davinci_wdt);
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1660202 — Re: [PATCH] watchdog: davinci: Handle return value of clk_prepare_enable

On Tue, Jun 06, 2017 at 03:47:53PM +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/davinci_wdt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index 0e731d7..1ba9ead 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -173,7 +173,11 @@ static int davinci_wdt_probe(struct platform_device *pdev)
>  		return PTR_ERR(davinci_wdt->clk);
>  	}
>  
> -	clk_prepare_enable(davinci_wdt->clk);
> +	ret = clk_prepare_enable(davinci_wdt->clk);
> +	if (ret) {
> +		dev_err(&pdev->dev, "failed to prepare clock\n");
> +		return ret;
> +	}
>  
>  	platform_set_drvdata(pdev, davinci_wdt);
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web