Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1660125 > unrolled thread

[PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk

Started byAlex Williamson <alex.williamson@redhat.com>
First post2017-06-07 21:10 +0200
Last post2017-06-13 00:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Alex Williamson <alex.williamson@redhat.com> - 2017-06-07 21:10 +0200
    Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Jesse Brandeburg <jesse.brandeburg@intel.com> - 2017-06-08 19:20 +0200
    Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk Bjorn Helgaas <helgaas@kernel.org> - 2017-06-13 00:00 +0200

#1660125 — [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk

FromAlex Williamson <alex.williamson@redhat.com>
Date2017-06-07 21:10 +0200
Subject[PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk
Message-ID<tPOv8-2fF-25@gated-at.bofh.it>
Just like the other XL710 and X710 variants, the XXV710 device IDs
appear to have the same hardware bug, the status register doesn't
report pending interrupts resulting in "irq xx: nobody cared..."
errors from the spurious interrupt handler when we try to use it
with device assignment.

Reported-by: Stefan Assmann <sassmann@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/pci/quirks.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 16e6cd86ad71..aa1c9e65f562 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3236,6 +3236,10 @@ static void quirk_broken_intx_masking(struct pci_dev *dev)
 			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1589,
 			quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158a,
+			quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158b,
+			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d0,
 			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d1,

[toc] | [next] | [standalone]


#1661503

FromJesse Brandeburg <jesse.brandeburg@intel.com>
Date2017-06-08 19:20 +0200
Message-ID<tQ9ge-76r-7@gated-at.bofh.it>
In reply to#1660125
On Wed, 7 Jun 2017 13:00:48 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:

> Just like the other XL710 and X710 variants, the XXV710 device IDs
> appear to have the same hardware bug, the status register doesn't
> report pending interrupts resulting in "irq xx: nobody cared..."
> errors from the spurious interrupt handler when we try to use it
> with device assignment.

Thanks for doing this Alex,

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

[toc] | [prev] | [next] | [standalone]


#1664256

FromBjorn Helgaas <helgaas@kernel.org>
Date2017-06-13 00:00 +0200
Message-ID<tRFxo-7G9-13@gated-at.bofh.it>
In reply to#1660125
On Wed, Jun 07, 2017 at 01:00:48PM -0600, Alex Williamson wrote:
> Just like the other XL710 and X710 variants, the XXV710 device IDs
> appear to have the same hardware bug, the status register doesn't
> report pending interrupts resulting in "irq xx: nobody cared..."
> errors from the spurious interrupt handler when we try to use it
> with device assignment.
> 
> Reported-by: Stefan Assmann <sassmann@redhat.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>

Applied with Jesse's ack to pci/virtualization for v4.13, thanks!

> ---
>  drivers/pci/quirks.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 16e6cd86ad71..aa1c9e65f562 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3236,6 +3236,10 @@ static void quirk_broken_intx_masking(struct pci_dev *dev)
>  			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1589,
>  			quirk_broken_intx_masking);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158a,
> +			quirk_broken_intx_masking);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x158b,
> +			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d0,
>  			quirk_broken_intx_masking);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x37d1,
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web