Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1658862 > unrolled thread

[PATCH -next] drm: pl111: select DRM_PANEL

Started byRandy Dunlap <rdunlap@infradead.org>
First post2017-06-06 17:30 +0200
Last post2017-06-07 21:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH -next] drm: pl111: select DRM_PANEL Randy Dunlap <rdunlap@infradead.org> - 2017-06-06 17:30 +0200
    Re: [PATCH -next] drm: pl111: select DRM_PANEL Eric Anholt <eric@anholt.net> - 2017-06-07 21:00 +0200

#1658862 — [PATCH -next] drm: pl111: select DRM_PANEL

FromRandy Dunlap <rdunlap@infradead.org>
Date2017-06-06 17:30 +0200
Subject[PATCH -next] drm: pl111: select DRM_PANEL
Message-ID<tPoAF-27S-7@gated-at.bofh.it>
From: Randy Dunlap <rdunlap@infradead.org>

The drm pl111 driver uses drm_panel interfaces so it should select
DRM_PANEL to fix build errors.

drivers/built-in.o: In function `pl111_connector_destroy':
pl111_connector.c:(.text+0xc7285): undefined reference to `drm_panel_detach'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/gpu/drm/pl111/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170606.orig/drivers/gpu/drm/pl111/Kconfig
+++ linux-next-20170606/drivers/gpu/drm/pl111/Kconfig
@@ -3,6 +3,7 @@ config DRM_PL111
 	depends on DRM
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on COMMON_CLK
+	select DRM_PANEL
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER

[toc] | [next] | [standalone]


#1660112

FromEric Anholt <eric@anholt.net>
Date2017-06-07 21:00 +0200
Message-ID<tPOls-1X8-17@gated-at.bofh.it>
In reply to#1658862

[Multipart message — attachments visible in raw view] — view raw

Randy Dunlap <rdunlap@infradead.org> writes:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> The drm pl111 driver uses drm_panel interfaces so it should select
> DRM_PANEL to fix build errors.
>
> drivers/built-in.o: In function `pl111_connector_destroy':
> pl111_connector.c:(.text+0xc7285): undefined reference to `drm_panel_detach'

This should have been fixed a week ago:

commit e7cc23de3e4e9222ae4fd24a00583aa5d2ed7610
Author:     Arnd Bergmann <arnd@arndb.de>
AuthorDate: Tue May 30 11:22:08 2017 +0200
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Wed May 31 09:32:32 2017 +0200

    drm/pl111: select DRM_PANEL

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web