Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1659196 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2017-06-06 23:00 +0200 |
| Last post | 2017-06-07 21:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH net-next 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-06-06 23:00 +0200
Re: [PATCH net-next 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN Florian Fainelli <f.fainelli@gmail.com> - 2017-06-07 21:40 +0200
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-06-06 23:00 +0200 |
| Subject | [PATCH net-next 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN |
| Message-ID | <tPtK1-5mC-1@gated-at.bofh.it> |
Now that the DSA core adds the CPU and DSA ports itself to the new VLAN entry, there is no need to include them as members of this VLAN when initializing a new VTU entry. As of now, initialize a new VTU entry with all ports excluded. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 93078bbe3cb5..522f023bb17e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -1159,11 +1159,10 @@ static int mv88e6xxx_vtu_get(struct mv88e6xxx_chip *chip, u16 vid, entry->valid = true; entry->vid = vid; - /* Include only CPU and DSA ports */ + /* Exclude all ports */ for (i = 0; i < mv88e6xxx_num_ports(chip); ++i) - entry->member[i] = dsa_is_normal_port(chip->ds, i) ? - GLOBAL_VTU_DATA_MEMBER_TAG_NON_MEMBER : - GLOBAL_VTU_DATA_MEMBER_TAG_UNMODIFIED; + entry->member[i] = + GLOBAL_VTU_DATA_MEMBER_TAG_NON_MEMBER; return mv88e6xxx_atu_new(chip, &entry->fid); } -- 2.13.0
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-06-07 21:40 +0200 |
| Subject | Re: [PATCH net-next 4/5] net: dsa: mv88e6xxx: exclude all ports in new VLAN |
| Message-ID | <tPOYa-2pK-21@gated-at.bofh.it> |
| In reply to | #1659196 |
On 06/06/2017 01:56 PM, Vivien Didelot wrote: > Now that the DSA core adds the CPU and DSA ports itself to the new VLAN > entry, there is no need to include them as members of this VLAN when > initializing a new VTU entry. > > As of now, initialize a new VTU entry with all ports excluded. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web