Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1660056 > unrolled thread
| Started by | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| First post | 2017-06-07 20:20 +0200 |
| Last post | 2017-06-09 02:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] devfreq: exynos-ppmu: Staticize event list Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-07 20:20 +0200
Re: [PATCH] devfreq: exynos-ppmu: Staticize event list Chanwoo Choi <cw00.choi@samsung.com> - 2017-06-08 03:30 +0200
RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-06-09 02:30 +0200
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-06-07 20:20 +0200 |
| Subject | [PATCH] devfreq: exynos-ppmu: Staticize event list |
| Message-ID | <tPNIJ-1Ge-1@gated-at.bofh.it> |
The ppmu_events array is accessed only in this compilation unit so it
can be made static.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/devfreq/event/exynos-ppmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 9b7350935b73..c68f3b5a10b5 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -44,7 +44,7 @@ struct exynos_ppmu {
{ "ppmu-event2-"#name, PPMU_PMNCNT2 }, \
{ "ppmu-event3-"#name, PPMU_PMNCNT3 }
-struct __exynos_ppmu_events {
+static struct __exynos_ppmu_events {
char *name;
int id;
} ppmu_events[] = {
--
2.9.3
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2017-06-08 03:30 +0200 |
| Message-ID | <tPUqR-5YQ-3@gated-at.bofh.it> |
| In reply to | #1660056 |
Hi Krzysztof,
On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote:
> The ppmu_events array is accessed only in this compilation unit so it
> can be made static.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 9b7350935b73..c68f3b5a10b5 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -44,7 +44,7 @@ struct exynos_ppmu {
> { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \
> { "ppmu-event3-"#name, PPMU_PMNCNT3 }
>
> -struct __exynos_ppmu_events {
> +static struct __exynos_ppmu_events {
> char *name;
> int id;
> } ppmu_events[] = {
>
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
[toc] | [prev] | [next] | [standalone]
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2017-06-09 02:30 +0200 |
| Message-ID | <tQfYm-2PQ-7@gated-at.bofh.it> |
| In reply to | #1660644 |
> Hi Krzysztof,
>
> On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote:
> > The ppmu_events array is accessed only in this compilation unit so it
> > can be made static.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/devfreq/event/exynos-ppmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> > index 9b7350935b73..c68f3b5a10b5 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -44,7 +44,7 @@ struct exynos_ppmu {
> > { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \
> > { "ppmu-event3-"#name, PPMU_PMNCNT3 }
> >
> > -struct __exynos_ppmu_events {
> > +static struct __exynos_ppmu_events {
> > char *name;
> > int id;
> > } ppmu_events[] = {
> >
>
> Looks good to me.
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Cheers,
MyungJoo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web