Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660024 > unrolled thread

Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-07 19:10 +0200
    Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-18 02:30 +0200

#1660024 — Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

On Mon, Mar 27, 2017 at 09:35:45PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 27, 2017 at 10:53:59AM -0700, Dmitry Torokhov wrote:
> > On Sun, Feb 12, 2017 at 04:36:19PM -0800, Dmitry Torokhov wrote:
> > > Many drivers create additional driver-specific device attributes when
> > > binding to the device and providing managed version of sysfs_create_group()
> > > will simplify unbinding and error handling in probe path for such drivers.
> > > 
> > > Without managed version driver writers either have to mix manual and
> > > managed resources, which is prone to errors, or open-code this function by
> > > providing a wrapper to sysfs_create_group() and use it with
> > > devm_add_action() or devm_add_action_or_reset().
> > > 
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > ---
> > 
> > Greg, gentle ping...
> 
> It's not lost, it's in my queue...

Another gentle ping...

-- 
Dmitry

[toc] | [next] | [standalone]

#1668495

On Wed, Jun 07, 2017 at 10:04:45AM -0700, Dmitry Torokhov wrote:
> On Mon, Mar 27, 2017 at 09:35:45PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Mar 27, 2017 at 10:53:59AM -0700, Dmitry Torokhov wrote:
> > > On Sun, Feb 12, 2017 at 04:36:19PM -0800, Dmitry Torokhov wrote:
> > > > Many drivers create additional driver-specific device attributes when
> > > > binding to the device and providing managed version of sysfs_create_group()
> > > > will simplify unbinding and error handling in probe path for such drivers.
> > > > 
> > > > Without managed version driver writers either have to mix manual and
> > > > managed resources, which is prone to errors, or open-code this function by
> > > > providing a wrapper to sysfs_create_group() and use it with
> > > > devm_add_action() or devm_add_action_or_reset().
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > ---
> > > 
> > > Greg, gentle ping...
> > 
> > It's not lost, it's in my queue...
> 
> Another gentle ping...

Ugh, I've been hoping you would forget about this :)

But, in thinking a lot about this recently, I have now come to the same
conclusion as you, I think we really need this as there isn't a way to
handle it any other way.

So, can you rebase and resend these patches?  I don't have them in my
queue anymore and I'd like to play with them and see how they work.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web