Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659300 > unrolled thread

[PATCH] cifs: remove redundant return in cifs_creation_time_get

Back to article view | Back to linux.kernel

Contents

  [PATCH] cifs: remove redundant return in cifs_creation_time_get Colin King <colin.king@canonical.com> - 2017-06-07 01:40 +0200
    Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get Aurélien Aptel <aaptel@suse.com> - 2017-06-07 15:10 +0200

#1659300 — [PATCH] cifs: remove redundant return in cifs_creation_time_get

From: Colin Ian King <colin.king@canonical.com>

There is a redundant return in function cifs_creation_time_get
that appears to be old vestigial code than can be removed. So
remove it.

Detected by CoverityScan, CID#1361924 ("Structurally dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/cifs/xattr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
index 3cb5c9e2d4e7..de50e749ff05 100644
--- a/fs/cifs/xattr.c
+++ b/fs/cifs/xattr.c
@@ -188,8 +188,6 @@ static int cifs_creation_time_get(struct dentry *dentry, struct inode *inode,
 	pcreatetime = (__u64 *)value;
 	*pcreatetime = CIFS_I(inode)->createtime;
 	return sizeof(__u64);
-
-	return rc;
 }
 
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1659780

Looks good to me.

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web