Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657866 > unrolled thread

[PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 18:50 +0200
    Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API Dan Williams <dan.j.williams@intel.com> - 2017-06-05 18:50 +0200
      Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-05 19:20 +0200
        Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API Christoph Hellwig <hch@lst.de> - 2017-06-05 23:30 +0200
          Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API "Williams, Dan J" <dan.j.williams@intel.com> - 2017-06-07 08:30 +0200
            Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-07 11:40 +0200
              Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API "hch@lst.de" <hch@lst.de> - 2017-06-07 12:20 +0200
            Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API "hch@lst.de" <hch@lst.de> - 2017-06-07 12:30 +0200

#1657866 — [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API

There are new types and helpers that are supposed to be used in new code.

As a preparation to get rid of legacy types and API functions do
the conversion here.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/nfit/core.c | 54 ++++++++++++++++++++++++------------------------
 drivers/acpi/nfit/nfit.h |  3 +--
 include/linux/acpi.h     |  1 +
 3 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 656acb5d7166..d9b39d0e9d6a 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -74,11 +74,11 @@ struct nfit_table_prev {
 	struct list_head flushes;
 };
 
-static u8 nfit_uuid[NFIT_UUID_MAX][16];
+static guid_t nfit_uuid[NFIT_UUID_MAX];
 
-const u8 *to_nfit_uuid(enum nfit_uuids id)
+const guid_t *to_nfit_uuid(enum nfit_uuids id)
 {
-	return nfit_uuid[id];
+	return &nfit_uuid[id];
 }
 EXPORT_SYMBOL(to_nfit_uuid);
 
@@ -222,7 +222,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
 	u32 offset, fw_status = 0;
 	acpi_handle handle;
 	unsigned int func;
-	const u8 *uuid;
+	const guid_t *guid;
 	int rc, i;
 
 	func = cmd;
@@ -245,7 +245,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
 		cmd_mask = nvdimm_cmd_mask(nvdimm);
 		dsm_mask = nfit_mem->dsm_mask;
 		desc = nd_cmd_dimm_desc(cmd);
-		uuid = to_nfit_uuid(nfit_mem->family);
+		guid = to_nfit_uuid(nfit_mem->family);
 		handle = adev->handle;
 	} else {
 		struct acpi_device *adev = to_acpi_dev(acpi_desc);
@@ -254,7 +254,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
 		cmd_mask = nd_desc->cmd_mask;
 		dsm_mask = cmd_mask;
 		desc = nd_cmd_bus_desc(cmd);
-		uuid = to_nfit_uuid(NFIT_DEV_BUS);
+		guid = to_nfit_uuid(NFIT_DEV_BUS);
 		handle = adev->handle;
 		dimm_name = "bus";
 	}
@@ -289,7 +289,7 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
 			in_buf.buffer.pointer,
 			min_t(u32, 256, in_buf.buffer.length), true);
 
-	out_obj = acpi_evaluate_dsm(handle, uuid, 1, func, &in_obj);
+	out_obj = acpi_evaluate_dsm(handle, guid.b, 1, func, &in_obj);
 	if (!out_obj) {
 		dev_dbg(dev, "%s:%s _DSM failed cmd: %s\n", __func__, dimm_name,
 				cmd_name);
@@ -409,7 +409,7 @@ int nfit_spa_type(struct acpi_nfit_system_address *spa)
 	int i;
 
 	for (i = 0; i < NFIT_UUID_MAX; i++)
-		if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == 0)
+		if (guid_equal(to_nfit_uuid(i), (guid_t *)&spa->range_guid))
 			return i;
 	return -1;
 }
@@ -1415,7 +1415,7 @@ static int acpi_nfit_add_dimm(struct acpi_nfit_desc *acpi_desc,
 	struct acpi_device *adev, *adev_dimm;
 	struct device *dev = acpi_desc->dev;
 	unsigned long dsm_mask;
-	const u8 *uuid;
+	const guid_t *guid;
 	int i;
 	int family = -1;
 
@@ -1444,7 +1444,7 @@ static int acpi_nfit_add_dimm(struct acpi_nfit_desc *acpi_desc,
 	/*
 	 * Until standardization materializes we need to consider 4
 	 * different command sets.  Note, that checking for function0 (bit0)
-	 * tells us if any commands are reachable through this uuid.
+	 * tells us if any commands are reachable through this GUID.
 	 */
 	for (i = NVDIMM_FAMILY_INTEL; i <= NVDIMM_FAMILY_MSFT; i++)
 		if (acpi_check_dsm(adev_dimm->handle, to_nfit_uuid(i), 1, 1))
@@ -1474,9 +1474,9 @@ static int acpi_nfit_add_dimm(struct acpi_nfit_desc *acpi_desc,
 		return 0;
 	}
 
-	uuid = to_nfit_uuid(nfit_mem->family);
+	guid = to_nfit_uuid(nfit_mem->family);
 	for_each_set_bit(i, &dsm_mask, BITS_PER_LONG)
-		if (acpi_check_dsm(adev_dimm->handle, uuid, 1, 1ULL << i))
+		if (acpi_check_dsm(adev_dimm->handle, guid.b, 1, 1ULL << i))
 			set_bit(i, &nfit_mem->dsm_mask);
 
 	return 0;
@@ -1611,7 +1611,7 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc)
 static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
 {
 	struct nvdimm_bus_descriptor *nd_desc = &acpi_desc->nd_desc;
-	const u8 *uuid = to_nfit_uuid(NFIT_DEV_BUS);
+	const guid_t *guid = to_nfit_uuid(NFIT_DEV_BUS);
 	struct acpi_device *adev;
 	int i;
 
@@ -1621,7 +1621,7 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
 		return;
 
 	for (i = ND_CMD_ARS_CAP; i <= ND_CMD_CLEAR_ERROR; i++)
-		if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i))
+		if (acpi_check_dsm(adev->handle, guid.b, 1, 1ULL << i))
 			set_bit(i, &nd_desc->cmd_mask);
 }
 
@@ -3051,19 +3051,19 @@ static __init int nfit_init(void)
 	BUILD_BUG_ON(sizeof(struct acpi_nfit_control_region) != 80);
 	BUILD_BUG_ON(sizeof(struct acpi_nfit_data_region) != 40);
 
-	acpi_str_to_uuid(UUID_VOLATILE_MEMORY, nfit_uuid[NFIT_SPA_VOLATILE]);
-	acpi_str_to_uuid(UUID_PERSISTENT_MEMORY, nfit_uuid[NFIT_SPA_PM]);
-	acpi_str_to_uuid(UUID_CONTROL_REGION, nfit_uuid[NFIT_SPA_DCR]);
-	acpi_str_to_uuid(UUID_DATA_REGION, nfit_uuid[NFIT_SPA_BDW]);
-	acpi_str_to_uuid(UUID_VOLATILE_VIRTUAL_DISK, nfit_uuid[NFIT_SPA_VDISK]);
-	acpi_str_to_uuid(UUID_VOLATILE_VIRTUAL_CD, nfit_uuid[NFIT_SPA_VCD]);
-	acpi_str_to_uuid(UUID_PERSISTENT_VIRTUAL_DISK, nfit_uuid[NFIT_SPA_PDISK]);
-	acpi_str_to_uuid(UUID_PERSISTENT_VIRTUAL_CD, nfit_uuid[NFIT_SPA_PCD]);
-	acpi_str_to_uuid(UUID_NFIT_BUS, nfit_uuid[NFIT_DEV_BUS]);
-	acpi_str_to_uuid(UUID_NFIT_DIMM, nfit_uuid[NFIT_DEV_DIMM]);
-	acpi_str_to_uuid(UUID_NFIT_DIMM_N_HPE1, nfit_uuid[NFIT_DEV_DIMM_N_HPE1]);
-	acpi_str_to_uuid(UUID_NFIT_DIMM_N_HPE2, nfit_uuid[NFIT_DEV_DIMM_N_HPE2]);
-	acpi_str_to_uuid(UUID_NFIT_DIMM_N_MSFT, nfit_uuid[NFIT_DEV_DIMM_N_MSFT]);
+	guid_parse(UUID_VOLATILE_MEMORY, &nfit_uuid[NFIT_SPA_VOLATILE]);
+	guid_parse(UUID_PERSISTENT_MEMORY, &nfit_uuid[NFIT_SPA_PM]);
+	guid_parse(UUID_CONTROL_REGION, &nfit_uuid[NFIT_SPA_DCR]);
+	guid_parse(UUID_DATA_REGION, &nfit_uuid[NFIT_SPA_BDW]);
+	guid_parse(UUID_VOLATILE_VIRTUAL_DISK, &nfit_uuid[NFIT_SPA_VDISK]);
+	guid_parse(UUID_VOLATILE_VIRTUAL_CD, &nfit_uuid[NFIT_SPA_VCD]);
+	guid_parse(UUID_PERSISTENT_VIRTUAL_DISK, &nfit_uuid[NFIT_SPA_PDISK]);
+	guid_parse(UUID_PERSISTENT_VIRTUAL_CD, &nfit_uuid[NFIT_SPA_PCD]);
+	guid_parse(UUID_NFIT_BUS, &nfit_uuid[NFIT_DEV_BUS]);
+	guid_parse(UUID_NFIT_DIMM, &nfit_uuid[NFIT_DEV_DIMM]);
+	guid_parse(UUID_NFIT_DIMM_N_HPE1, &nfit_uuid[NFIT_DEV_DIMM_N_HPE1]);
+	guid_parse(UUID_NFIT_DIMM_N_HPE2, &nfit_uuid[NFIT_DEV_DIMM_N_HPE2]);
+	guid_parse(UUID_NFIT_DIMM_N_MSFT, &nfit_uuid[NFIT_DEV_DIMM_N_MSFT]);
 
 	nfit_wq = create_singlethread_workqueue("nfit");
 	if (!nfit_wq)
diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h
index 58fb7d68e04a..29bdd959517f 100644
--- a/drivers/acpi/nfit/nfit.h
+++ b/drivers/acpi/nfit/nfit.h
@@ -18,7 +18,6 @@
 #include <linux/libnvdimm.h>
 #include <linux/ndctl.h>
 #include <linux/types.h>
-#include <linux/uuid.h>
 #include <linux/acpi.h>
 #include <acpi/acuuid.h>
 
@@ -237,7 +236,7 @@ static inline struct acpi_nfit_desc *to_acpi_desc(
 	return container_of(nd_desc, struct acpi_nfit_desc, nd_desc);
 }
 
-const u8 *to_nfit_uuid(enum nfit_uuids id);
+const guid_t *to_nfit_uuid(enum nfit_uuids id);
 int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, void *nfit, acpi_size sz);
 void acpi_nfit_shutdown(void *data);
 void __acpi_nfit_notify(struct device *dev, acpi_handle handle, u32 event);
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 137e4a3d89c5..b0e1636ca5c3 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -39,6 +39,7 @@
 #include <linux/dynamic_debug.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/uuid.h>
 
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
-- 
2.11.0

[toc] | [next] | [standalone]

#1657874

On Mon, Jun 5, 2017 at 9:40 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/acpi/nfit/core.c | 54 ++++++++++++++++++++++++------------------------
>  drivers/acpi/nfit/nfit.h |  3 +--
>  include/linux/acpi.h     |  1 +
>  3 files changed, 29 insertions(+), 29 deletions(-)

Is there a git branch with these available, so I can run it through
the nvdimm regression suite?

[toc] | [prev] | [next] | [standalone]

#1657976

On Mon, 2017-06-05 at 09:49 -0700, Dan Williams wrote:
> On Mon, Jun 5, 2017 at 9:40 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > There are new types and helpers that are supposed to be used in new
> > code.
> > 
> > As a preparation to get rid of legacy types and API functions do
> > the conversion here.

I hope Christoph can replace old version of this series with new one in
his uuid branch. URL in cover letter, repeating for your convenience:

[1]: git://git.infradead.org/users/hch/uuid.git

> > 
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/acpi/nfit/core.c | 54 ++++++++++++++++++++++++-------------
> > -----------
> >  drivers/acpi/nfit/nfit.h |  3 +--
> >  include/linux/acpi.h     |  1 +
> >  3 files changed, 29 insertions(+), 29 deletions(-)
> 
> Is there a git branch with these available, so I can run it through
> the nvdimm regression suite?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1658154

On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote:
> I hope Christoph can replace old version of this series with new one in
> his uuid branch. URL in cover letter, repeating for your convenience:
> 
> [1]: git://git.infradead.org/users/hch/uuid.git

Yeah, but I had to drop it again after noticing the guid_equals bits,
and after not fixing up the GUID -> GUID_INIT rename.

for-next in the above repo should have the proper base now, and acpi
has the ACPI bits for Dan to test.

[toc] | [prev] | [next] | [standalone]

#1659403

On Mon, 2017-06-05 at 23:22 +-0200, Christoph Hellwig wrote:
+AD4- On Mon, Jun 05, 2017 at 08:10:42PM +-0300, Andy Shevchenko wrote:
+AD4- +AD4- 
+AD4- +AD4- I hope Christoph can replace old version of this series with new
+AD4- +AD4- one in
+AD4- +AD4- his uuid branch. URL in cover letter, repeating for your
+AD4- +AD4- convenience:
+AD4- +AD4- 
+AD4- +AD4- +AFs-1+AF0-: git://git.infradead.org/users/hch/uuid.git
+AD4- 
+AD4- Yeah, but I had to drop it again after noticing the guid+AF8-equals bits,
+AD4- and after not fixing up the GUID -+AD4- GUID+AF8-INIT rename.
+AD4- 
+AD4- for-next in the above repo should have the proper base now, and acpi
+AD4- has the ACPI bits for Dan to test.

With one compile fix below the 'acpi' branch works for me. Please feel
free to add:

Tested-by: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4-

...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and
tools/testing/nvdimm, but I'm ok if you omit it if the branch is about
to go immutable. Speaking of which, let me know when it does go
immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7
needs some new guid handling code.

Please apply the following or fold it into commit+AKA-c793ed7ccf42 +ACI-ACPI:
Switch to use generic guid+AF8-t in acpi+AF8-evaluate+AF8-dsm()+ACI-

-----+AD4-8-----
From 18b82755ea839bdc94127aebf0e2f788c19224f3 Mon Sep 17 00:00:00 2001
From: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4-
Date: Tue, 6 Jun 2017 22:41:40 -0700
Subject: +AFs-PATCH+AF0- tools/testing/nvdimm: guid+AF8-t compile fix
MIME-Version: 1.0
Content-Type: text/plain+ADs- charset+AD0-UTF-8
Content-Transfer-Encoding: 8bit

Fix up the declaration of the nfit+AF8-test+AF8-evaluate+AF8-dsm+AF8-fn type, to avoid
compile errors of the form:

    tools/testing/nvdimm/test/iomap.c: In function +IBgAXwBf-wrap+AF8-acpi+AF8-evaluate+AF8-dsm+IBk-:
    tools/testing/nvdimm/test/iomap.c:382:35: error: passing argument 2 of
    	+IBg-ops-+AD4-evaluate+AF8-dsm+IBk- from incompatible pointer type

       obj +AD0- ops-+AD4-evaluate+AF8-dsm(handle, guid, rev, func, argv4)+ADs-
                                   +AF4AfgB+AH4-
Signed-off-by: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4-
---
 tools/testing/nvdimm/test/nfit+AF8-test.h +AHw- 3 +-+--
 1 file changed, 2 insertions(+-), 1 deletion(-)

diff --git a/tools/testing/nvdimm/test/nfit+AF8-test.h b/tools/testing/nvdimm/test/nfit+AF8-test.h
index f54c0032c6ff..c4e80104165a 100644
--- a/tools/testing/nvdimm/test/nfit+AF8-test.h
+-+-+- b/tools/testing/nvdimm/test/nfit+AF8-test.h
+AEAAQA- -13,6 +-13,7 +AEAAQA-
 +ACM-ifndef +AF8AXw-NFIT+AF8-TEST+AF8-H+AF8AXw-
 +ACM-define +AF8AXw-NFIT+AF8-TEST+AF8-H+AF8AXw-
 +ACM-include +ADw-linux/list.h+AD4-
+-+ACM-include +ADw-linux/uuid.h+AD4-
 +ACM-include +ADw-linux/ioport.h+AD4-
 +ACM-include +ADw-linux/spinlock+AF8-types.h+AD4-
 
+AEAAQA- -36,7 +-37,7 +AEAAQA- typedef void +ACo-acpi+AF8-handle+ADs-
 
 typedef struct nfit+AF8-test+AF8-resource +ACo-(+ACo-nfit+AF8-test+AF8-lookup+AF8-fn)(resource+AF8-size+AF8-t)+ADs-
 typedef union acpi+AF8-object +ACo-(+ACo-nfit+AF8-test+AF8-evaluate+AF8-dsm+AF8-fn)(acpi+AF8-handle handle,
-		const u8 +ACo-uuid, u64 rev, u64 func, union acpi+AF8-object +ACo-argv4)+ADs-
+-		const guid+AF8-t +ACo-guid, u64 rev, u64 func, union acpi+AF8-object +ACo-argv4)+ADs-
 void +AF8AXw-iomem +ACoAXwBf-wrap+AF8-ioremap+AF8-nocache(resource+AF8-size+AF8-t offset,
 		unsigned long size)+ADs-
 void +AF8AXw-wrap+AF8-iounmap(volatile void +AF8AXw-iomem +ACo-addr)+ADs-
-- 
2.9.4

[toc] | [prev] | [next] | [standalone]

#1659605

On Wed, 2017-06-07 at 06:25 +0000, Williams, Dan J wrote:
> On Mon, 2017-06-05 at 23:22 +0200, Christoph Hellwig wrote:
> > On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote:
> > > 
> > > I hope Christoph can replace old version of this series with new
> > > one in
> > > his uuid branch. URL in cover letter, repeating for your
> > > convenience:
> > > 
> > > [1]: git://git.infradead.org/users/hch/uuid.git
> > 
> > Yeah, but I had to drop it again after noticing the guid_equals
> > bits,
> > and after not fixing up the GUID -> GUID_INIT rename.
> > 
> > for-next in the above repo should have the proper base now, and acpi
> > has the ACPI bits for Dan to test.
> 
> With one compile fix below the 'acpi' branch works for me. Please feel
> free to add:
> 
> Tested-by: Dan Williams <dan.j.williams@intel.com>

Thanks, Dan!

I probably missed some configuration option since I have done
compilation many times.

> 
> ...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and
> tools/testing/nvdimm, but I'm ok if you omit it if the branch is about
> to go immutable. Speaking of which, let me know when it does go
> immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7
> needs some new guid handling code.
> 

> Please apply the following or fold it into commit c793ed7ccf42 "ACPI:
> Switch to use generic guid_t in acpi_evaluate_dsm()"

It think we may fold it.

Besides that we might need the following fix as well.

--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -638,7 +638,7 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t
*guid, u64 rev, u64 func,
 
 	params[0].type = ACPI_TYPE_BUFFER;
 	params[0].buffer.length = 16;
-	params[0].buffer.pointer = (u8 *)&guid;
+	params[0].buffer.pointer = (u8 *)guid;
 	params[1].type = ACPI_TYPE_INTEGER;
 	params[1].integer.value = rev;
 	params[2].type = ACPI_TYPE_INTEGER;

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1659645

On Wed, Jun 07, 2017 at 12:37:51PM +0300, Andy Shevchenko wrote:
> It think we may fold it.

Yes, I'll fold it and delcare the tree stable late tonight my time.

> Besides that we might need the following fix as well.

Yeah.  Another reasone why buffer.pointer should be a void pointer.

[toc] | [prev] | [next] | [standalone]

#1659653

On Wed, Jun 07, 2017 at 06:25:46AM +0000, Williams, Dan J wrote:
> With one compile fix below the 'acpi' branch works for me. Please feel
> free to add:

The mail seems to contain garbage that can't be applied, but I just
applied the changes manually.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web