Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656958 > unrolled thread

[PATCH 0/4] Fixed comment coding style issues.

Started bysrishti sharma <srishtishar@gmail.com>
First post2017-06-04 01:40 +0200
Last post2017-06-04 01:40 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/4] Fixed comment coding style issues. srishti sharma <srishtishar@gmail.com> - 2017-06-04 01:40 +0200
    [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block. srishti sharma <srishtishar@gmail.com> - 2017-06-04 01:40 +0200
      Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on  subsequent lines of a comment block. Greg KH <gregkh@linuxfoundation.org> - 2017-06-04 10:30 +0200
        Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on  subsequent lines of a comment block. srishti sharma <srishtishar@gmail.com> - 2017-06-06 15:50 +0200
    [PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block srishti sharma <srishtishar@gmail.com> - 2017-06-04 01:40 +0200

#1656958 — [PATCH 0/4] Fixed comment coding style issues.

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-04 01:40 +0200
Subject[PATCH 0/4] Fixed comment coding style issues.
Message-ID<tOqOd-56H-3@gated-at.bofh.it>
This patchset contains a series of comment coding style issues fixes.

srishti sharma (4):
  Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
    comment block.
  Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment
    block
  Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment
    block
  Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
    comment block

 drivers/staging/ccree/cc_crypto_ctx.h | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]


#1656959 — [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-04 01:40 +0200
Subject[PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.
Message-ID<tOqOe-56H-15@gated-at.bofh.it>
In reply to#1656958
Added * on subsequent lines of a comment block.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h
index ac39d34..6ee51b8 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -219,7 +219,7 @@ struct drv_ctx_hash {
 };

 /* !!!! drv_ctx_hmac should have the same structure as drv_ctx_hash except
-   k0, k0_size fields */
+ * k0, k0_size fields */
 struct drv_ctx_hmac {
	enum drv_crypto_alg alg; /* DRV_CRYPTO_ALG_HMAC */
	enum drv_hash_mode mode;
--
2.7.4

[toc] | [prev] | [next] | [standalone]


#1657027 — Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-04 10:30 +0200
SubjectRe: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.
Message-ID<tOz57-2iK-1@gated-at.bofh.it>
In reply to#1656959
On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote:
> Added * on subsequent lines of a comment block.
> 
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This whole series also does not apply.  Note, this driver is under
active development, you are probably running into the problem that lots
of people are working on it at the same time.

sorry,

greg k-h

[toc] | [prev] | [next] | [standalone]


#1658780 — Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-06 15:50 +0200
SubjectRe: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.
Message-ID<tPn1U-12m-21@gated-at.bofh.it>
In reply to#1657027
On Sun, Jun 4, 2017 at 1:49 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote:
>> Added * on subsequent lines of a comment block.
>>
>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This whole series also does not apply.  Note, this driver is under
> active development, you are probably running into the problem that lots
> of people are working on it at the same time.
>
> sorry,
>
> greg k-h



Okay , Thanks a lot !

Regards,
Srishti

[toc] | [prev] | [next] | [standalone]


#1656960 — [PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-04 01:40 +0200
Subject[PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block
Message-ID<tOqOe-56H-19@gated-at.bofh.it>
In reply to#1656958
Added *'s on subsequent lines of a comment block to fix coding style issues.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h
index 03164624..a8747d5 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -281,9 +281,9 @@ struct drv_ctx_aead {


 /* Get the address of a @member within a given @ctx address
-   @ctx: The context address
-   @type: Type of context structure
-   @member: Associated context field */
+ * @ctx: The context address
+ * @type: Type of context structure
+ * @member: Associated context field */
 #define GET_CTX_FIELD_ADDR(ctx, type, member) (ctx + offsetof(type, member))

 #endif /* _CC_CRYPTO_CTX_H_ */
--
2.7.4

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web