Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654696 > unrolled thread
| Started by | Andrea Adami <andrea.adami@gmail.com> |
|---|---|
| First post | 2017-06-01 00:50 +0200 |
| Last post | 2017-06-05 10:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 3/9] mfd: tmio.h: support partition parser types Andrea Adami <andrea.adami@gmail.com> - 2017-06-01 00:50 +0200
Re: [PATCH v3 3/9] mfd: tmio.h: support partition parser types Wolfram Sang <wsa@the-dreams.de> - 2017-06-01 10:50 +0200
Re: [PATCH v3 3/9] mfd: tmio.h: support partition parser types Lee Jones <lee.jones@linaro.org> - 2017-06-01 16:40 +0200
Re: [PATCH v3 3/9] mfd: tmio.h: support partition parser types Andrea Adami <andrea.adami@gmail.com> - 2017-06-03 23:50 +0200
Re: [PATCH v3 3/9] mfd: tmio.h: support partition parser types Lee Jones <lee.jones@linaro.org> - 2017-06-05 10:00 +0200
| From | Andrea Adami <andrea.adami@gmail.com> |
|---|---|
| Date | 2017-06-01 00:50 +0200 |
| Subject | [PATCH v3 3/9] mfd: tmio.h: support partition parser types |
| Message-ID | <tNkBb-2ET-19@gated-at.bofh.it> |
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
include/linux/mfd/tmio.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index a1520d8..23bb069 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -139,6 +139,7 @@ struct tmio_nand_data {
struct nand_bbt_descr *badblock_pattern;
struct mtd_partition *partition;
unsigned int num_partitions;
+ const char *const *types; /* names of parsers to use if any */
};
#define FBIO_TMIO_ACC_WRITE 0x7C639300
--
2.7.4
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-06-01 10:50 +0200 |
| Message-ID | <tNtXQ-fI-11@gated-at.bofh.it> |
| In reply to | #1654696 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Jun 01, 2017 at 12:40:52AM +0200, Andrea Adami wrote: > Signed-off-by: Andrea Adami <andrea.adami@gmail.com> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-06-01 16:40 +0200 |
| Message-ID | <tNzqy-3Jw-11@gated-at.bofh.it> |
| In reply to | #1654696 |
On Thu, 01 Jun 2017, Andrea Adami wrote:
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
> include/linux/mfd/tmio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index a1520d8..23bb069 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -139,6 +139,7 @@ struct tmio_nand_data {
> struct nand_bbt_descr *badblock_pattern;
> struct mtd_partition *partition;
> unsigned int num_partitions;
> + const char *const *types; /* names of parsers to use if any */
Please use kerneldoc instead.
> };
>
> #define FBIO_TMIO_ACC_WRITE 0x7C639300
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Andrea Adami <andrea.adami@gmail.com> |
|---|---|
| Date | 2017-06-03 23:50 +0200 |
| Message-ID | <tOp5L-3Sp-5@gated-at.bofh.it> |
| In reply to | #1655193 |
On Thu, Jun 1, 2017 at 4:35 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Thu, 01 Jun 2017, Andrea Adami wrote:
>
>> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
>> ---
>> include/linux/mfd/tmio.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
>> index a1520d8..23bb069 100644
>> --- a/include/linux/mfd/tmio.h
>> +++ b/include/linux/mfd/tmio.h
>> @@ -139,6 +139,7 @@ struct tmio_nand_data {
>> struct nand_bbt_descr *badblock_pattern;
>> struct mtd_partition *partition;
>> unsigned int num_partitions;
>> + const char *const *types; /* names of parsers to use if any */
>
> Please use kerneldoc instead.
>
Thanks for the review.
tmio.h is not consistent and uses inline comments so I did not change the style.
Another round of patches will be necessary to sanitize the comments,
out of the scope of this little patchset.
Cheers
Andrea
>> };
>>
>> #define FBIO_TMIO_ACC_WRITE 0x7C639300
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-06-05 10:00 +0200 |
| Message-ID | <tOV5D-8tP-1@gated-at.bofh.it> |
| In reply to | #1656936 |
On Sat, 03 Jun 2017, Andrea Adami wrote:
> On Thu, Jun 1, 2017 at 4:35 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Thu, 01 Jun 2017, Andrea Adami wrote:
> >
> >> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> >> ---
> >> include/linux/mfd/tmio.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> >> index a1520d8..23bb069 100644
> >> --- a/include/linux/mfd/tmio.h
> >> +++ b/include/linux/mfd/tmio.h
> >> @@ -139,6 +139,7 @@ struct tmio_nand_data {
> >> struct nand_bbt_descr *badblock_pattern;
> >> struct mtd_partition *partition;
> >> unsigned int num_partitions;
> >> + const char *const *types; /* names of parsers to use if any */
> >
> > Please use kerneldoc instead.
> >
> Thanks for the review.
>
> tmio.h is not consistent and uses inline comments so I did not change the style.
> Another round of patches will be necessary to sanitize the comments,
> out of the scope of this little patchset.
Will you do the work?
> >> };
> >>
> >> #define FBIO_TMIO_ACC_WRITE 0x7C639300
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web