Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1657176 > unrolled thread

[PATCH] net: sched: fix mips build failure

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: sched: fix mips build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-06-04 23:50 +0200
    Re: [PATCH] net: sched: fix mips build failure Jiri Pirko <jiri@resnulli.us> - 2017-06-05 07:00 +0200

#1657176 — [PATCH] net: sched: fix mips build failure

The build of mips ar7_defconfig was failing with the error:
../net/sched/act_api.c: In function 'tcf_action_goto_chain_init':
../net/sched/act_api.c:37:18: error:
	implicit declaration of function 'tcf_chain_get'
	[-Werror=implicit-function-declaration]

../net/sched/act_api.c: In function 'tcf_action_goto_chain_fini':
../net/sched/act_api.c:45:2: error:
	implicit declaration of function 'tcf_chain_put'
	[-Werror=implicit-function-declaration]

Add two inline helpers for the case where CONFIG_NET_CLS is not enabled.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---

The build log of the latest linux-next is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/238623031/

 include/net/pkt_cls.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 537d0a0..c34ade5 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -29,6 +29,17 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
 
 #else
 static inline
+struct tcf_chain *tcf_chain_get(struct tcf_block *block,
+				u32 chain_index, bool create)
+{
+	return NULL;
+}
+
+static inline void tcf_chain_put(struct tcf_chain *chain)
+{
+}
+
+static inline
 int tcf_block_get(struct tcf_block **p_block,
 		  struct tcf_proto __rcu **p_filter_chain)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1657269

Sun, Jun 04, 2017 at 11:44:13PM CEST, sudipm.mukherjee@gmail.com wrote:
>The build of mips ar7_defconfig was failing with the error:
>../net/sched/act_api.c: In function 'tcf_action_goto_chain_init':
>../net/sched/act_api.c:37:18: error:
>	implicit declaration of function 'tcf_chain_get'
>	[-Werror=implicit-function-declaration]
>
>../net/sched/act_api.c: In function 'tcf_action_goto_chain_fini':
>../net/sched/act_api.c:45:2: error:
>	implicit declaration of function 'tcf_chain_put'
>	[-Werror=implicit-function-declaration]
>
>Add two inline helpers for the case where CONFIG_NET_CLS is not enabled.
>
>Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

I already sent a fix for this:

http://patchwork.ozlabs.org/project/netdev/list/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web