Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657141 > unrolled thread
| Started by | Vladimir Davydov <vdavydov.dev@gmail.com> |
|---|---|
| First post | 2017-06-04 21:30 +0200 |
| Last post | 2017-06-04 21:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-06-04 21:30 +0200
| From | Vladimir Davydov <vdavydov.dev@gmail.com> |
|---|---|
| Date | 2017-06-04 21:30 +0200 |
| Subject | Re: [RFC PATCH v2 1/7] mm, oom: refactor select_bad_process() to take memcg as an argument |
| Message-ID | <tOJnP-Yc-5@gated-at.bofh.it> |
On Thu, Jun 01, 2017 at 07:35:09PM +0100, Roman Gushchin wrote: > The select_bad_process() function will be used further > to select a process to kill in the victim cgroup. > This cgroup doesn't necessary match oc->memcg, > which is a cgroup, which limits were caused cgroup-wide OOM > (or NULL in case of global OOM). > > So, refactor select_bad_process() to take a pointer to > a cgroup to iterate over as an argument. IMHO this patch, as well as patches 2-5, doesn't deserve to be submitted separately: none of them make sense as a separate change; worse, patches 4 and 5 introduce user API that doesn't do anything without patch 6. All of the changes are relatively small and singling them out doesn't really facilitate review, so I'd merge them all in patch 6.
Back to top | Article view | linux.kernel
csiph-web