Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1655092 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-01 14:30 +0200 |
| Last post | 2017-06-01 18:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] net: dsa: make function ksz_rcv static Colin King <colin.king@canonical.com> - 2017-06-01 14:30 +0200
RE: [PATCH][net-next] net: dsa: make function ksz_rcv static <Woojung.Huh@microchip.com> - 2017-06-01 16:00 +0200
Re: [PATCH][net-next] net: dsa: make function ksz_rcv static David Miller <davem@davemloft.net> - 2017-06-01 18:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-01 14:30 +0200 |
| Subject | [PATCH][net-next] net: dsa: make function ksz_rcv static |
| Message-ID | <tNxoL-2tN-27@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
function ksz_rcv can be made static as it does not need to be
in global scope. Reformat arguments to make it checkpatch warning
free too.
Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should
it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/dsa/tag_ksz.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c
index 0b08a40b493a..dfcd2fff5b13 100644
--- a/net/dsa/tag_ksz.c
+++ b/net/dsa/tag_ksz.c
@@ -72,8 +72,9 @@ static struct sk_buff *ksz_xmit(struct sk_buff *skb, struct net_device *dev)
return nskb;
}
-struct sk_buff *ksz_rcv(struct sk_buff *skb, struct net_device *dev,
- struct packet_type *pt, struct net_device *orig_dev)
+static struct sk_buff *ksz_rcv(struct sk_buff *skb, struct net_device *dev,
+ struct packet_type *pt,
+ struct net_device *orig_dev)
{
struct dsa_switch_tree *dst = dev->dsa_ptr;
struct dsa_switch *ds;
--
2.11.0
[toc] | [next] | [standalone]
| From | <Woojung.Huh@microchip.com> |
|---|---|
| Date | 2017-06-01 16:00 +0200 |
| Message-ID | <tNyNP-3fE-3@gated-at.bofh.it> |
| In reply to | #1655092 |
> function ksz_rcv can be made static as it does not need to be > in global scope. Reformat arguments to make it checkpatch warning > free too. > > Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should > it be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Woojung Huh <Woojung.Huh@microchip.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-06-01 18:20 +0200 |
| Message-ID | <tNAZj-4Q6-5@gated-at.bofh.it> |
| In reply to | #1655092 |
From: Colin King <colin.king@canonical.com> Date: Thu, 1 Jun 2017 13:22:42 +0100 > From: Colin Ian King <colin.king@canonical.com> > > function ksz_rcv can be made static as it does not need to be > in global scope. Reformat arguments to make it checkpatch warning > free too. > > Cleans up sparse warning: "symbol 'ksz_rcv' was not declared. Should > it be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web