Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1655111 > unrolled thread
| Started by | Jean Delvare <jdelvare@suse.de> |
|---|---|
| First post | 2017-06-01 14:50 +0200 |
| Last post | 2017-06-01 14:50 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string Jean Delvare <jdelvare@suse.de> - 2017-06-01 14:50 +0200
| From | Jean Delvare <jdelvare@suse.de> |
|---|---|
| Date | 2017-06-01 14:50 +0200 |
| Subject | Re: [PATCH v2 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string |
| Message-ID | <tNxI6-2Aw-19@gated-at.bofh.it> |
I did not notice before, but now that I'm testing... On Wed, 17 May 2017 13:25:12 +0300, Mika Westerberg wrote: > --- a/drivers/firmware/dmi-id.c > +++ b/drivers/firmware/dmi-id.c > @@ -47,6 +47,7 @@ DEFINE_DMI_ATTR_WITH_SHOW(product_name, 0444, DMI_PRODUCT_NAME); > DEFINE_DMI_ATTR_WITH_SHOW(product_version, 0444, DMI_PRODUCT_VERSION); > DEFINE_DMI_ATTR_WITH_SHOW(product_serial, 0400, DMI_PRODUCT_SERIAL); > DEFINE_DMI_ATTR_WITH_SHOW(product_uuid, 0400, DMI_PRODUCT_UUID); > +DEFINE_DMI_ATTR_WITH_SHOW(product_family, 0400, DMI_PRODUCT_FAMILY); > DEFINE_DMI_ATTR_WITH_SHOW(board_vendor, 0444, DMI_BOARD_VENDOR); > DEFINE_DMI_ATTR_WITH_SHOW(board_name, 0444, DMI_BOARD_NAME); > DEFINE_DMI_ATTR_WITH_SHOW(board_version, 0444, DMI_BOARD_VERSION); I see no reason to hide this field from users. Permissions 0444 would seem more appropriate. I'll include that change in my patch if there are no objections. -- Jean Delvare SUSE L3 Support
Back to top | Article view | linux.kernel
csiph-web