Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650522 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-25 15:50 +0200 |
| Last post | 2017-06-01 12:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] qtnfmac: remove duplicated assignment to mac Colin King <colin.king@canonical.com> - 2017-05-25 15:50 +0200
Re: [net-next] qtnfmac: remove duplicated assignment to mac Kalle Valo <kvalo@codeaurora.org> - 2017-06-01 12:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-25 15:50 +0200 |
| Subject | [PATCH][net-next] qtnfmac: remove duplicated assignment to mac |
| Message-ID | <tL1jk-pv-21@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
mac is being assigned twice, remove redundant 2nd assignment.
Detected by CoverityScan, CID#1437554 ("Incorrect expression")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index fc0ce2c09097..e3c090008125 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
void qtnf_virtual_intf_cleanup(struct net_device *ndev)
{
struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
- struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
+ struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
if (vif->wdev.iftype == NL80211_IFTYPE_STATION) {
switch (vif->sta_state) {
--
2.11.0
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-06-01 12:00 +0200 |
| Subject | Re: [net-next] qtnfmac: remove duplicated assignment to mac |
| Message-ID | <tNv3D-Uw-45@gated-at.bofh.it> |
| In reply to | #1650522 |
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Patch applied to wireless-drivers-next.git, thanks.
4f8e25458cb6 qtnfmac: remove duplicated assignment to mac
--
https://patchwork.kernel.org/patch/9748407/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web