Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652817 > unrolled thread

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

Started byByungchul Park <byungchul.park@lge.com>
First post2017-05-30 07:40 +0200
Last post2017-06-01 09:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use  existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-05-30 07:40 +0200
    Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use  existing llist API Frederic Weisbecker <fweisbec@gmail.com> - 2017-05-31 16:10 +0200
      Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use  existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-06-01 09:40 +0200

#1652817 — Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

FromByungchul Park <byungchul.park@lge.com>
Date2017-05-30 07:40 +0200
SubjectRe: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API
Message-ID<tMI2R-2WP-1@gated-at.bofh.it>
On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.

+to peterz@infradead.org
+to mingo@kernel.org
+to rostedt@goodmis.org

I am not sure whom should I send this patch to..
Could you check this if you are right person?

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/irq_work.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index bcf107c..e2ebe8c 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -138,11 +138,7 @@ static void irq_work_run_list(struct llist_head *list)
>  		return;
>  
>  	llnode = llist_del_all(list);
> -	while (llnode != NULL) {
> -		work = llist_entry(llnode, struct irq_work, llnode);
> -
> -		llnode = llist_next(llnode);
> -
> +	llist_for_each_entry(work, llnode, llnode) {
>  		/*
>  		 * Clear the PENDING bit, after this point the @work
>  		 * can be re-used.
> -- 
> 1.9.1

[toc] | [next] | [standalone]


#1654277

FromFrederic Weisbecker <fweisbec@gmail.com>
Date2017-05-31 16:10 +0200
Message-ID<tNctZ-5S4-33@gated-at.bofh.it>
In reply to#1652817
On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > Although llist provides proper APIs, they are not used. Make them used.
> 
> +to peterz@infradead.org
> +to mingo@kernel.org
> +to rostedt@goodmis.org
> 
> I am not sure whom should I send this patch to..
> Could you check this if you are right person?

I'll take it.

Thanks!

[toc] | [prev] | [next] | [standalone]


#1654887

FromByungchul Park <byungchul.park@lge.com>
Date2017-06-01 09:40 +0200
Message-ID<tNsS5-81U-1@gated-at.bofh.it>
In reply to#1654277
On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote:
> On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote:
> > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote:
> > > Although llist provides proper APIs, they are not used. Make them used.
> > 
> > +to peterz@infradead.org
> > +to mingo@kernel.org
> > +to rostedt@goodmis.org
> > 
> > I am not sure whom should I send this patch to..
> > Could you check this if you are right person?
> 
> I'll take it.

Hi, Frederic,

Thank you.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web