Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653434 > unrolled thread
| Started by | Michael Kelley <mikelley@microsoft.com> |
|---|---|
| First post | 2017-05-30 19:50 +0200 |
| Last post | 2017-06-01 01:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Michael Kelley <mikelley@microsoft.com> - 2017-05-30 19:50 +0200
Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Joe Perches <joe@perches.com> - 2017-05-30 20:10 +0200
Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations David Miller <davem@davemloft.net> - 2017-05-31 20:10 +0200
Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations Joe Perches <joe@perches.com> - 2017-06-01 01:00 +0200
Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations David Miller <davem@davemloft.net> - 2017-06-01 01:30 +0200
| From | Michael Kelley <mikelley@microsoft.com> |
|---|---|
| Date | 2017-05-30 19:50 +0200 |
| Subject | [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations |
| Message-ID | <tMTrj-1TY-1@gated-at.bofh.it> |
Add direct #include statements for declarations of csum_tcpudp_magic() and csum_ipv6_magic(). While the needed #include's are picked up indirectly for the x86 architecture, they aren't on other architectures, resulting in compile errors. Signed-off-by: Michael Kelley <mikelley@microsoft.com> --- drivers/net/hyperv/netvsc_drv.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4421a6d..ca952b3 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -37,6 +37,8 @@ #include <net/route.h> #include <net/sock.h> #include <net/pkt_sched.h> +#include <asm/checksum.h> +#include <net/ip6_checksum.h> #include "hyperv_net.h" -- 1.7.1
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-05-30 20:10 +0200 |
| Subject | Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations |
| Message-ID | <tMTKF-2ga-7@gated-at.bofh.it> |
| In reply to | #1653434 |
On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote: > Add direct #include statements for declarations of csum_tcpudp_magic() > and csum_ipv6_magic(). While the needed #include's are picked up > indirectly for the x86 architecture, they aren't on other > architectures, resulting in compile errors. [] > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index 4421a6d..ca952b3 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -37,6 +37,8 @@ > #include <net/route.h> > #include <net/sock.h> > #include <net/pkt_sched.h> > +#include <asm/checksum.h> Maybe #include <net/checksum.h> instead? > +#include <net/ip6_checksum.h> > > #include "hyperv_net.h" >
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-05-31 20:10 +0200 |
| Subject | Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations |
| Message-ID | <tNgee-8ge-21@gated-at.bofh.it> |
| In reply to | #1653434 |
From: Michael Kelley <mikelley@microsoft.com> Date: Tue, 30 May 2017 10:43:04 -0700 > Add direct #include statements for declarations of csum_tcpudp_magic() > and csum_ipv6_magic(). While the needed #include's are picked up > indirectly for the x86 architecture, they aren't on other > architectures, resulting in compile errors. > > Signed-off-by: Michael Kelley <mikelley@microsoft.com> Applied, thank you.
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-06-01 01:00 +0200 |
| Subject | Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations |
| Message-ID | <tNkKS-2Is-5@gated-at.bofh.it> |
| In reply to | #1654518 |
On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: > From: Michael Kelley <mikelley@microsoft.com> > Date: Tue, 30 May 2017 10:43:04 -0700 > > > Add direct #include statements for declarations of csum_tcpudp_magic() > > and csum_ipv6_magic(). While the needed #include's are picked up > > indirectly for the x86 architecture, they aren't on other > > architectures, resulting in compile errors. > > > > Signed-off-by: Michael Kelley <mikelley@microsoft.com> > > Applied, thank you. Did you apply this one or the v2?
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-06-01 01:30 +0200 |
| Subject | Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations |
| Message-ID | <tNldT-37F-1@gated-at.bofh.it> |
| In reply to | #1654710 |
From: Joe Perches <joe@perches.com> Date: Wed, 31 May 2017 15:59:31 -0700 > On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: >> From: Michael Kelley <mikelley@microsoft.com> >> Date: Tue, 30 May 2017 10:43:04 -0700 >> >> > Add direct #include statements for declarations of csum_tcpudp_magic() >> > and csum_ipv6_magic(). While the needed #include's are picked up >> > indirectly for the x86 architecture, they aren't on other >> > architectures, resulting in compile errors. >> > >> > Signed-off-by: Michael Kelley <mikelley@microsoft.com> >> >> Applied, thank you. > > Did you apply this one or the v2? I got v2 which used net/checksum.h et al.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web