Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1650161 > unrolled thread

Re: [linux-sunxi] [PATCH v3 3/9] ASoC: sun8i-codec-analog: add support for V3s SoC

Started byChen-Yu Tsai <wens@csie.org>
First post2017-05-25 06:10 +0200
Last post2017-05-31 19:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [linux-sunxi] [PATCH v3 3/9] ASoC: sun8i-codec-analog: add  support for V3s SoC Chen-Yu Tsai <wens@csie.org> - 2017-05-25 06:10 +0200
    Re: [linux-sunxi] [PATCH v3 3/9] ASoC: sun8i-codec-analog: add  support for V3s SoC Rob Herring <robh@kernel.org> - 2017-05-31 19:30 +0200

#1650161 — Re: [linux-sunxi] [PATCH v3 3/9] ASoC: sun8i-codec-analog: add support for V3s SoC

FromChen-Yu Tsai <wens@csie.org>
Date2017-05-25 06:10 +0200
SubjectRe: [linux-sunxi] [PATCH v3 3/9] ASoC: sun8i-codec-analog: add support for V3s SoC
Message-ID<tKSg2-3dw-31@gated-at.bofh.it>
On Wed, May 24, 2017 at 6:06 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> From: Icenowy Zheng <icenowy@aosc.xyz>
>
> The V3s SoC features an analog codec with headphone support but without
> mic2 and linein.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Mark, please hold off on applying this patch until the comments from the
previous patch have been addressed. They should be applied in order.

> ---
>  Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt | 1 +
>  sound/soc/sunxi/sun8i-codec-analog.c                           | 9 +++++++++

Also, is there a preference for splitting out device tree binding
changes from driver changes?

Thanks
ChenYu

[toc] | [next] | [standalone]


#1654479

FromRob Herring <robh@kernel.org>
Date2017-05-31 19:30 +0200
Message-ID<tNfBw-7MH-7@gated-at.bofh.it>
In reply to#1650161
On Thu, May 25, 2017 at 11:58:37AM +0800, Chen-Yu Tsai wrote:
> On Wed, May 24, 2017 at 6:06 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > From: Icenowy Zheng <icenowy@aosc.xyz>
> >
> > The V3s SoC features an analog codec with headphone support but without
> > mic2 and linein.
> >
> > Add support for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> 
> Mark, please hold off on applying this patch until the comments from the
> previous patch have been addressed. They should be applied in order.
> 
> > ---
> >  Documentation/devicetree/bindings/sound/sun8i-codec-analog.txt | 1 +
> >  sound/soc/sunxi/sun8i-codec-analog.c                           | 9 +++++++++
> 
> Also, is there a preference for splitting out device tree binding
> changes from driver changes?

Yes, but not necessary for a 1 line change.

Rob

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web