Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654208 > unrolled thread

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue. srishti sharma <srishtishar@gmail.com> - 2017-05-31 15:00 +0200
    Re: [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding  style issue. Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200

#1654208 — [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/cc_crypto_ctx.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h
index c5784bc..38f6615 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -239,10 +239,10 @@ struct drv_ctx_cipher {
 	enum drv_crypto_padding_type padding_type;
 	u32 key_size; /* numeric value in bytes   */
 	u32 data_unit_size; /* required for XTS */
-	/* block_state is the AES engine block state.
-	*  It is used by the host to pass IV or counter at initialization.
-	*  It is used by SeP for intermediate block chaining state and for
-	*  returning MAC algorithms results.           */
+	/*  block_state is the AES engine block state.
+	 *  It is used by the host to pass IV or counter at initialization.
+	 *  It is used by SeP for intermediate block chaining state and for
+	 *  returning MAC algorithms results.           */
 	u8 block_state[CC_AES_BLOCK_SIZE];
 	u8 key[CC_AES_KEY_SIZE_MAX];
 	u8 xex_key[CC_AES_KEY_SIZE_MAX];
2.7.4

[toc] | [next] | [standalone]

#1656821 — Re: [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

On Wed, May 31, 2017 at 06:24:55PM +0530, srishti sharma wrote:
> Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line.
> 

Please properly line-wrap your changelog comments :(

You also sent 2 different patches, that did different things, yet they
had the same subject line.  That's not ok, and also, I have no idea
which one to apply first.

I'm dropping both, please fix and resend them properly as a patch
series.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web