Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654946 > unrolled thread

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

Started bychangbin.du@intel.com
First post2017-06-01 11:10 +0200
Last post2017-06-02 06:30 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du@intel.com - 2017-06-01 11:10 +0200
    Re: [PATCH] perf sort: only insert overhead && overhead_children  when no overhead* field given Jiri Olsa <jolsa@redhat.com> - 2017-06-01 12:30 +0200
      Re: [PATCH] perf sort: only insert overhead && overhead_children  when no overhead* field given "Du, Changbin" <changbin.du@intel.com> - 2017-06-02 05:00 +0200
        Re: [PATCH] perf sort: only insert overhead && overhead_children  when no overhead* field given "Du, Changbin" <changbin.du@intel.com> - 2017-06-02 05:30 +0200
    [PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du@intel.com - 2017-06-02 06:30 +0200

#1654946 — [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

Fromchangbin.du@intel.com
Date2017-06-01 11:10 +0200
Subject[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Message-ID<tNuhb-Bs-13@gated-at.bofh.it>
From: Changbin Du <changbin.du@intel.com>

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first.Ths will be a problem if the data is collected with call-graph
enabled. Then we never can sort the result as self-overhead on this
data. And sometimes the data is hard to collect.

This patch fix this by only insert overhead && overhead_children
when no overhead* field given.

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 5762ae4..69eea3a 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
 	if (sort__mode == SORT_MODE__DIFF)
 		return keys;
 
+	if (strstr(keys, "overhead"))
+		return keys;
+
 	keys = prefix_if_not_in("overhead", keys);
 
 	if (symbol_conf.cumulate_callchain)
-- 
2.7.4

[toc] | [next] | [standalone]

#1654987 — Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

FromJiri Olsa <jolsa@redhat.com>
Date2017-06-01 12:30 +0200
SubjectRe: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Message-ID<tNvwB-1jB-5@gated-at.bofh.it>
In reply to#1654946
On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first.Ths will be a problem if the data is collected with call-graph
> enabled. Then we never can sort the result as self-overhead on this
> data. And sometimes the data is hard to collect.
> 
> This patch fix this by only insert overhead && overhead_children
> when no overhead* field given.
> 
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
>  tools/perf/util/sort.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 5762ae4..69eea3a 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
>  	if (sort__mode == SORT_MODE__DIFF)
>  		return keys;
>  
> +	if (strstr(keys, "overhead"))
> +		return keys;
> +
>  	keys = prefix_if_not_in("overhead", keys);

hum, you basicaly do what's at begining of prefix_if_not_in function:

static char *prefix_if_not_in(const char *pre, char *str)
{
        char *n;

        if (!str || strstr(str, pre))
                return str;
        ...


could you please provide the example described in changelog?

jirka

[toc] | [prev] | [next] | [standalone]

#1655859 — Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

From"Du, Changbin" <changbin.du@intel.com>
Date2017-06-02 05:00 +0200
SubjectRe: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Message-ID<tNKYG-377-5@gated-at.bofh.it>
In reply to#1654987

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote:
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 5762ae4..69eea3a 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> >  	if (sort__mode == SORT_MODE__DIFF)
> >  		return keys;
> >  
> > +	if (strstr(keys, "overhead"))
> > +		return keys;
> > +
> >  	keys = prefix_if_not_in("overhead", keys);
> 
> hum, you basicaly do what's at begining of prefix_if_not_in function:
> 
> static char *prefix_if_not_in(const char *pre, char *str)
> {
>         char *n;
> 
>         if (!str || strstr(str, pre))
>                 return str;
>         ...
> 
Thanks, will change it.

> 
> could you please provide the example described in changelog?
> 
Will add example cmdline there, Thanks.

> jirka

-- 
Thanks,
Changbin Du

[toc] | [prev] | [next] | [standalone]

#1655867 — Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

From"Du, Changbin" <changbin.du@intel.com>
Date2017-06-02 05:30 +0200
SubjectRe: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Message-ID<tNLrH-3yD-9@gated-at.bofh.it>
In reply to#1655859

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jun 02, 2017 at 10:52:24AM +0800, Du, Changbin wrote:
> On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> > On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote:
> > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > > index 5762ae4..69eea3a 100644
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > >  	if (sort__mode == SORT_MODE__DIFF)
> > >  		return keys;
> > >  
> > > +	if (strstr(keys, "overhead"))
> > > +		return keys;
> > > +
> > >  	keys = prefix_if_not_in("overhead", keys);
> > 
> > hum, you basicaly do what's at begining of prefix_if_not_in function:
> > 
> > static char *prefix_if_not_in(const char *pre, char *str)
> > {
> >         char *n;
> > 
> >         if (!str || strstr(str, pre))
> >                 return str;
> >         ...
> > 
> Thanks, will change it.
>
Misunderstood your words. This is not equal to prefix_if_not_in.
# perf record -ag
# perf report -s overhead,sym

Samples: 7K of event 'cycles', Event count (approx.): 865138253
  Children      Self  Symbol
  +   26.41%     0.00%  [k] verify_cpu
  +   26.37%     0.04%  [k] cpu_startup_entry
  +   25.93%     0.27%  [k] do_idle
  +   19.88%     0.00%  [k] start_secondary
  ....

'Children' should not be here.

> > 
> > could you please provide the example described in changelog?
> > 
> Will add example cmdline there, Thanks.
> 
> > jirka
> 
> -- 
> Thanks,
> Changbin Du



-- 
Thanks,
Changbin Du

[toc] | [prev] | [next] | [standalone]

#1655892 — [PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given

Fromchangbin.du@intel.com
Date2017-06-02 06:30 +0200
Subject[PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given
Message-ID<tNMnL-49A-5@gated-at.bofh.it>
In reply to#1654946
From: Changbin Du <changbin.du@intel.com>

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first.Ths will be a problem if the data is collected with call-graph
enabled. Then we never can sort the result as self-overhead on this
data. And sometimes the data is hard to collect.

> perf record -ag
> perf report -s overhead,sym

Samples: 7K of event 'cycles', Event count (approx.): 865138253
  Children      Self  Symbol
  +   26.41%     0.00%  [k] verify_cpu
  +   26.37%     0.04%  [k] cpu_startup_entry
  +   25.93%     0.27%  [k] do_idle
  +   19.88%     0.00%  [k] start_secondary
  ....

I intend to sort as 'Self', but actually it sort as 'Children'.

This patch fix this by only insert overhead && overhead_children
when no overhead* field given.

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
v2: Add the example in commit message.

---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 5762ae4..69eea3a 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
 	if (sort__mode == SORT_MODE__DIFF)
 		return keys;
 
+	if (strstr(keys, "overhead"))
+		return keys;
+
 	keys = prefix_if_not_in("overhead", keys);
 
 	if (symbol_conf.cumulate_callchain)
-- 
2.7.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web