Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1650847 > unrolled thread

Re: [PATCH v2 01/18] xen: introduce the pvcalls interface header

Started byBoris Ostrovsky <boris.ostrovsky@oracle.com>
First post2017-05-26 00:10 +0200
Last post2017-06-01 23:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2 01/18] xen: introduce the pvcalls interface header Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-05-26 00:10 +0200
    Re: [PATCH v2 01/18] xen: introduce the pvcalls interface header Stefano Stabellini <sstabellini@kernel.org> - 2017-06-01 23:00 +0200

#1650847 — Re: [PATCH v2 01/18] xen: introduce the pvcalls interface header

FromBoris Ostrovsky <boris.ostrovsky@oracle.com>
Date2017-05-26 00:10 +0200
SubjectRe: [PATCH v2 01/18] xen: introduce the pvcalls interface header
Message-ID<tL97b-5CD-9@gated-at.bofh.it>
On 05/19/2017 07:22 PM, Stefano Stabellini wrote:
> Introduce the C header file which defines the PV Calls interface. It is
> imported from xen/include/public/io/pvcalls.h.
>
> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> CC: konrad.wilk@oracle.com
> CC: boris.ostrovsky@oracle.com
> CC: jgross@suse.com
> ---
>  include/xen/interface/io/pvcalls.h | 120 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 120 insertions(+)
>  create mode 100644 include/xen/interface/io/pvcalls.h
>
> diff --git a/include/xen/interface/io/pvcalls.h b/include/xen/interface/io/pvcalls.h
> new file mode 100644
> index 0000000..0d41959
> --- /dev/null
> +++ b/include/xen/interface/io/pvcalls.h
> @@ -0,0 +1,120 @@
> +#ifndef __XEN_PUBLIC_IO_XEN_PVCALLS_H__
> +#define __XEN_PUBLIC_IO_XEN_PVCALLS_H__
> +
> +#include <linux/net.h>
> +#include "xen/interface/io/ring.h"
> +
> +/* "1" means socket, connect, release, bind, listen, accept and poll */
> +#define XENBUS_FUNCTIONS_CALLS "1"
> +
> +/*
> + * See docs/misc/pvcalls.markdown in xen.git for the full specification:
> + * https://xenbits.xen.org/docs/unstable/misc/pvcalls.html
> + */
> +struct pvcalls_data_intf {
> +    RING_IDX in_cons, in_prod, in_error;
> +
> +    uint8_t pad1[52];
> +
> +    RING_IDX out_cons, out_prod, out_error;
> +
> +    uint8_t pad2[52];
> +
> +    RING_IDX ring_order;
> +    grant_ref_t ref[];

I think you should also include <xen/interface/grant_table.h>.

In fact, ring.h probably needs to do it too.

-boris

[toc] | [next] | [standalone]


#1655754

FromStefano Stabellini <sstabellini@kernel.org>
Date2017-06-01 23:00 +0200
Message-ID<tNFmi-7IJ-3@gated-at.bofh.it>
In reply to#1650847
On Thu, 25 May 2017, Boris Ostrovsky wrote:
> On 05/19/2017 07:22 PM, Stefano Stabellini wrote:
> > Introduce the C header file which defines the PV Calls interface. It is
> > imported from xen/include/public/io/pvcalls.h.
> >
> > Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> > CC: konrad.wilk@oracle.com
> > CC: boris.ostrovsky@oracle.com
> > CC: jgross@suse.com
> > ---
> >  include/xen/interface/io/pvcalls.h | 120 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 120 insertions(+)
> >  create mode 100644 include/xen/interface/io/pvcalls.h
> >
> > diff --git a/include/xen/interface/io/pvcalls.h b/include/xen/interface/io/pvcalls.h
> > new file mode 100644
> > index 0000000..0d41959
> > --- /dev/null
> > +++ b/include/xen/interface/io/pvcalls.h
> > @@ -0,0 +1,120 @@
> > +#ifndef __XEN_PUBLIC_IO_XEN_PVCALLS_H__
> > +#define __XEN_PUBLIC_IO_XEN_PVCALLS_H__
> > +
> > +#include <linux/net.h>
> > +#include "xen/interface/io/ring.h"
> > +
> > +/* "1" means socket, connect, release, bind, listen, accept and poll */
> > +#define XENBUS_FUNCTIONS_CALLS "1"
> > +
> > +/*
> > + * See docs/misc/pvcalls.markdown in xen.git for the full specification:
> > + * https://xenbits.xen.org/docs/unstable/misc/pvcalls.html
> > + */
> > +struct pvcalls_data_intf {
> > +    RING_IDX in_cons, in_prod, in_error;
> > +
> > +    uint8_t pad1[52];
> > +
> > +    RING_IDX out_cons, out_prod, out_error;
> > +
> > +    uint8_t pad2[52];
> > +
> > +    RING_IDX ring_order;
> > +    grant_ref_t ref[];
> 
> I think you should also include <xen/interface/grant_table.h>.
> 
> In fact, ring.h probably needs to do it too.

I'll do, thanks

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web