Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654309 > unrolled thread
| Started by | Jon Hunter <jonathanh@nvidia.com> |
|---|---|
| First post | 2017-05-31 16:30 +0200 |
| Last post | 2017-06-01 18:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Jon Hunter <jonathanh@nvidia.com> - 2017-05-31 16:30 +0200
Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-06-01 08:40 +0200
Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Philipp Zabel <p.zabel@pengutronix.de> - 2017-06-01 18:50 +0200
| From | Jon Hunter <jonathanh@nvidia.com> |
|---|---|
| Date | 2017-05-31 16:30 +0200 |
| Subject | Re: [PATCH v4 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers |
| Message-ID | <tNcNj-5ZF-1@gated-at.bofh.it> |
On 22/05/17 12:23, Vivek Gautam wrote:
> Make use of reset_control_array_*() set of APIs to manage
> an array of reset controllers available with the device.
>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> drivers/soc/tegra/pmc.c | 91 +++++++++++++++++--------------------------------
> 1 file changed, 31 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index e233dd5dcab3..668f5d3d3635 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -124,8 +124,8 @@ struct tegra_powergate {
> unsigned int id;
> struct clk **clks;
> unsigned int num_clks;
> - struct reset_control **resets;
> - unsigned int num_resets;
> + struct reset_control *reset;
> + struct reset_control_array *resets;
It's a shame we can't avoid this additional reset pointer, but maybe
there is no good alternative for now. So ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
[toc] | [next] | [standalone]
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| Date | 2017-06-01 08:40 +0200 |
| Message-ID | <tNrW2-7pv-15@gated-at.bofh.it> |
| In reply to | #1654309 |
Hi,
On Wed, May 31, 2017 at 7:53 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
>
> On 22/05/17 12:23, Vivek Gautam wrote:
>> Make use of reset_control_array_*() set of APIs to manage
>> an array of reset controllers available with the device.
>>
>> Cc: Jon Hunter <jonathanh@nvidia.com>
>> Cc: Thierry Reding <treding@nvidia.com>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>> drivers/soc/tegra/pmc.c | 91 +++++++++++++++++--------------------------------
>> 1 file changed, 31 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
>> index e233dd5dcab3..668f5d3d3635 100644
>> --- a/drivers/soc/tegra/pmc.c
>> +++ b/drivers/soc/tegra/pmc.c
>> @@ -124,8 +124,8 @@ struct tegra_powergate {
>> unsigned int id;
>> struct clk **clks;
>> unsigned int num_clks;
>> - struct reset_control **resets;
>> - unsigned int num_resets;
>> + struct reset_control *reset;
>> + struct reset_control_array *resets;
>
> It's a shame we can't avoid this additional reset pointer, but maybe
> there is no good alternative for now. So ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
Thanks for the testing and Ack.
Best regards
Vivek
>
> Cheers
> Jon
>
> --
> nvpublic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2017-06-01 18:50 +0200 |
| Message-ID | <tNBsm-53m-37@gated-at.bofh.it> |
| In reply to | #1654309 |
Hi,
On Wed, 2017-05-31 at 15:23 +0100, Jon Hunter wrote:
> On 22/05/17 12:23, Vivek Gautam wrote:
> > Make use of reset_control_array_*() set of APIs to manage
> > an array of reset controllers available with the device.
> >
> > Cc: Jon Hunter <jonathanh@nvidia.com>
> > Cc: Thierry Reding <treding@nvidia.com>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> > ---
> > drivers/soc/tegra/pmc.c | 91 +++++++++++++++++--------------------------------
> > 1 file changed, 31 insertions(+), 60 deletions(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> > index e233dd5dcab3..668f5d3d3635 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -124,8 +124,8 @@ struct tegra_powergate {
> > unsigned int id;
> > struct clk **clks;
> > unsigned int num_clks;
> > - struct reset_control **resets;
> > - unsigned int num_resets;
> > + struct reset_control *reset;
> > + struct reset_control_array *resets;
>
> It's a shame we can't avoid this additional reset pointer, but maybe
> there is no good alternative for now. So ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
> Tested-by: Jon Hunter <jonathanh@nvidia.com>
Thanks. I don't see a big functional difference between a
reset_control_array and a reset_control, given that a single reset
control bit already controls multiple reset lines on some devices.
Maybe it would be preferable to let the reset_control_array_get
functions return a struct reset_control that hides the array.
I'll send a v5 to see if that would be sensible.
regards
Philipp
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web