Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1655315 > unrolled thread

[PATCH 3.16 198/212] net: ipv6: check route protocol when deleting routes

Started byBen Hutchings <ben@decadent.org.uk>
First post2017-06-01 18:00 +0200
Last post2017-06-01 18:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3.16 198/212] net: ipv6: check route protocol when  deleting routes Ben Hutchings <ben@decadent.org.uk> - 2017-06-01 18:00 +0200

#1655315 — [PATCH 3.16 198/212] net: ipv6: check route protocol when deleting routes

FromBen Hutchings <ben@decadent.org.uk>
Date2017-06-01 18:00 +0200
Subject[PATCH 3.16 198/212] net: ipv6: check route protocol when deleting routes
Message-ID<tNAG0-4sr-79@gated-at.bofh.it>
3.16.44-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Mantas M <grawity@gmail.com>

commit c2ed1880fd61a998e3ce40254a99a2ad000f1a7d upstream.

The protocol field is checked when deleting IPv4 routes, but ignored for
IPv6, which causes problems with routing daemons accidentally deleting
externally set routes (observed by multiple bird6 users).

This can be verified using `ip -6 route del <prefix> proto something`.

Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 net/ipv6/route.c | 2 ++
 1 file changed, 2 insertions(+)

--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1733,6 +1733,8 @@ static int ip6_route_del(struct fib6_con
 				continue;
 			if (cfg->fc_metric && cfg->fc_metric != rt->rt6i_metric)
 				continue;
+			if (cfg->fc_protocol && cfg->fc_protocol != rt->rt6i_protocol)
+				continue;
 			dst_hold(&rt->dst);
 			read_unlock_bh(&table->tb6_lock);
 

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web