Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654595 > unrolled thread

[PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

Started byJon Mason <jon.mason@broadcom.com>
First post2017-05-31 22:00 +0200
Last post2017-06-01 12:20 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP Jon Mason <jon.mason@broadcom.com> - 2017-05-31 22:00 +0200
    Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for  NS/NSP Florian Fainelli <f.fainelli@gmail.com> - 2017-05-31 22:10 +0200
    Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for  NS/NSP Eduardo Valentin <edubezval@gmail.com> - 2017-06-01 05:10 +0200
      Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP Jon Mason <jon.mason@broadcom.com> - 2017-06-01 18:00 +0200
    Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for  NS/NSP Rafał Miłecki <rafal@milecki.pl> - 2017-06-01 12:20 +0200

#1654595 — [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

FromJon Mason <jon.mason@broadcom.com>
Date2017-05-31 22:00 +0200
Subject[PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP
Message-ID<tNhWG-Ge-17@gated-at.bofh.it>
ARCH_BCM_IPROC includes support for many SoCs, not all of which have the
same thermal hardware interface as the Northstar/Northstar Plus SoCs.
This is not a major issue, as this driver will only be probed if the
relevant device tree entry is present.  However, it will result in a
slightly larger than necessary kernel.  By limiting the driver to only
work on the NS/NSP SoCs, we can avoid the issue.

Suggested-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
 drivers/thermal/broadcom/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
index 42c098e86f84..c729dad2348c 100644
--- a/drivers/thermal/broadcom/Kconfig
+++ b/drivers/thermal/broadcom/Kconfig
@@ -8,8 +8,8 @@ config BCM2835_THERMAL
 
 config BCM_NS_THERMAL
 	tristate "Northstar thermal driver"
-	depends on ARCH_BCM_IPROC || COMPILE_TEST
-	default y if ARCH_BCM_IPROC
+	depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST
+	default y if ARCH_BCM_NSP || ARCH_BCM_5301X
 	help
 	  Support for the Northstar and Northstar Plus family of SoCs (e.g.
 	  BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
-- 
2.7.4

[toc] | [next] | [standalone]

#1654603 — Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

FromFlorian Fainelli <f.fainelli@gmail.com>
Date2017-05-31 22:10 +0200
SubjectRe: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP
Message-ID<tNi6m-YB-17@gated-at.bofh.it>
In reply to#1654595
On 05/31/2017 12:55 PM, Jon Mason wrote:
> ARCH_BCM_IPROC includes support for many SoCs, not all of which have the
> same thermal hardware interface as the Northstar/Northstar Plus SoCs.
> This is not a major issue, as this driver will only be probed if the
> relevant device tree entry is present.  However, it will result in a
> slightly larger than necessary kernel.  By limiting the driver to only
> work on the NS/NSP SoCs, we can avoid the issue.
> 
> Suggested-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

[toc] | [prev] | [next] | [standalone]

#1654774 — Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

FromEduardo Valentin <edubezval@gmail.com>
Date2017-06-01 05:10 +0200
SubjectRe: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP
Message-ID<tNoEP-5s8-23@gated-at.bofh.it>
In reply to#1654595

[Multipart message — attachments visible in raw view] — view raw

On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote:
> ARCH_BCM_IPROC includes support for many SoCs, not all of which have the
> same thermal hardware interface as the Northstar/Northstar Plus SoCs.
> This is not a major issue, as this driver will only be probed if the
> relevant device tree entry is present.  However, it will result in a
> slightly larger than necessary kernel.  By limiting the driver to only
> work on the NS/NSP SoCs, we can avoid the issue.
> 
> Suggested-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>

Should this commit message include a Fixes: tag?

Maybe
Fixes: a94cb7e ("thermal: broadcom: add Northstar thermal driver")

> ---
>  drivers/thermal/broadcom/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
> index 42c098e86f84..c729dad2348c 100644
> --- a/drivers/thermal/broadcom/Kconfig
> +++ b/drivers/thermal/broadcom/Kconfig
> @@ -8,8 +8,8 @@ config BCM2835_THERMAL
>  
>  config BCM_NS_THERMAL
>  	tristate "Northstar thermal driver"
> -	depends on ARCH_BCM_IPROC || COMPILE_TEST
> -	default y if ARCH_BCM_IPROC
> +	depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST
> +	default y if ARCH_BCM_NSP || ARCH_BCM_5301X
>  	help
>  	  Support for the Northstar and Northstar Plus family of SoCs (e.g.
>  	  BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
> -- 
> 2.7.4
>

[toc] | [prev] | [next] | [standalone]

#1655297

FromJon Mason <jon.mason@broadcom.com>
Date2017-06-01 18:00 +0200
Message-ID<tNAFZ-4sr-33@gated-at.bofh.it>
In reply to#1654774
On Wed, May 31, 2017 at 11:09 PM, Eduardo Valentin <edubezval@gmail.com> wrote:
> On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote:
>> ARCH_BCM_IPROC includes support for many SoCs, not all of which have the
>> same thermal hardware interface as the Northstar/Northstar Plus SoCs.
>> This is not a major issue, as this driver will only be probed if the
>> relevant device tree entry is present.  However, it will result in a
>> slightly larger than necessary kernel.  By limiting the driver to only
>> work on the NS/NSP SoCs, we can avoid the issue.
>>
>> Suggested-by: Scott Branden <scott.branden@broadcom.com>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>
> Should this commit message include a Fixes: tag?
>
> Maybe
> Fixes: a94cb7e ("thermal: broadcom: add Northstar thermal driver")

Technically, it would be 2 patches

Fixes: a94cb7eeecc4 ("thermal: broadcom: add Northstar thermal driver")
Fixes: a54c51863ed1 ("thermal: broadcom: ns-thermal: default on iProc SoCs")

We could probably get away with only doing the latter one, as it is
the one that makes it enabled by default


>> ---
>>  drivers/thermal/broadcom/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
>> index 42c098e86f84..c729dad2348c 100644
>> --- a/drivers/thermal/broadcom/Kconfig
>> +++ b/drivers/thermal/broadcom/Kconfig
>> @@ -8,8 +8,8 @@ config BCM2835_THERMAL
>>
>>  config BCM_NS_THERMAL
>>       tristate "Northstar thermal driver"
>> -     depends on ARCH_BCM_IPROC || COMPILE_TEST
>> -     default y if ARCH_BCM_IPROC
>> +     depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST
>> +     default y if ARCH_BCM_NSP || ARCH_BCM_5301X
>>       help
>>         Support for the Northstar and Northstar Plus family of SoCs (e.g.
>>         BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
>> --
>> 2.7.4
>>

[toc] | [prev] | [next] | [standalone]

#1654985 — Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

FromRafał Miłecki <rafal@milecki.pl>
Date2017-06-01 12:20 +0200
SubjectRe: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP
Message-ID<tNvmW-1gl-19@gated-at.bofh.it>
In reply to#1654595
On 2017-05-31 21:55, Jon Mason wrote:
> ARCH_BCM_IPROC includes support for many SoCs, not all of which have 
> the
> same thermal hardware interface as the Northstar/Northstar Plus SoCs.
> This is not a major issue, as this driver will only be probed if the
> relevant device tree entry is present.  However, it will result in a
> slightly larger than necessary kernel.  By limiting the driver to only
> work on the NS/NSP SoCs, we can avoid the issue.
> 
> Suggested-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>

Sounds OK, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web