Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1654061 > unrolled thread
| Started by | Michael Thalmeier <michael.thalmeier@hale.at> |
|---|---|
| First post | 2017-05-31 11:50 +0200 |
| Last post | 2017-06-02 23:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] i2c: mxs: change error printing to debug for mxs_i2c_pio_wait_xfer_end Michael Thalmeier <michael.thalmeier@hale.at> - 2017-05-31 11:50 +0200
Re: [PATCH] i2c: mxs: change error printing to debug for mxs_i2c_pio_wait_xfer_end Wolfram Sang <wsa@the-dreams.de> - 2017-06-02 23:00 +0200
| From | Michael Thalmeier <michael.thalmeier@hale.at> |
|---|---|
| Date | 2017-05-31 11:50 +0200 |
| Subject | [PATCH] i2c: mxs: change error printing to debug for mxs_i2c_pio_wait_xfer_end |
| Message-ID | <tN8ql-31c-5@gated-at.bofh.it> |
Instead of printing errors after mxs_i2c_pio_wait_xfer_end returns with
an error code just print a debug message.
NAKs and timeouts can occur in this situation normally, so do not treat
them as errors.
Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
---
drivers/i2c/busses/i2c-mxs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 5738556..d4e8f19 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -419,7 +419,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
ret = mxs_i2c_pio_wait_xfer_end(i2c);
if (ret) {
- dev_err(i2c->dev,
+ dev_dbg(i2c->dev,
"PIO: Failed to send SELECT command!\n");
goto cleanup;
}
@@ -431,7 +431,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
ret = mxs_i2c_pio_wait_xfer_end(i2c);
if (ret) {
- dev_err(i2c->dev,
+ dev_dbg(i2c->dev,
"PIO: Failed to send READ command!\n");
goto cleanup;
}
@@ -528,7 +528,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
/* Wait for the end of the transfer. */
ret = mxs_i2c_pio_wait_xfer_end(i2c);
if (ret) {
- dev_err(i2c->dev,
+ dev_dbg(i2c->dev,
"PIO: Failed to finish WRITE cmd!\n");
break;
}
--
2.9.2
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-06-02 23:00 +0200 |
| Subject | Re: [PATCH] i2c: mxs: change error printing to debug for mxs_i2c_pio_wait_xfer_end |
| Message-ID | <tO1PP-65t-9@gated-at.bofh.it> |
| In reply to | #1654061 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, May 31, 2017 at 11:40:03AM +0200, Michael Thalmeier wrote: > Instead of printing errors after mxs_i2c_pio_wait_xfer_end returns with > an error code just print a debug message. > > NAKs and timeouts can occur in this situation normally, so do not treat > them as errors. > > Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at> Applied to for-next, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web