Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653989 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-05-31 10:30 +0200 |
| Last post | 2017-05-31 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mtd: nand: atmel: mark resume function __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-05-31 10:30 +0200
Re: [PATCH] mtd: nand: atmel: mark resume function __maybe_unused Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-31 16:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-31 10:30 +0200 |
| Subject | [PATCH] mtd: nand: atmel: mark resume function __maybe_unused |
| Message-ID | <tN7aX-2iQ-43@gated-at.bofh.it> |
The newly added suspend/resume support causes a harmless warning:
drivers/mtd/nand/atmel/nand-controller.c:2513:12: error: 'atmel_nand_controller_resume' defined but not used [-Werror=unused-function]
This shuts up the warning with a __maybe_unused annotation.
Fixes: b107007a7114 ("mtd: nand: atmel: Add PM ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/atmel/nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
index 6055831c953f..d24e67b95167 100644
--- a/drivers/mtd/nand/atmel/nand-controller.c
+++ b/drivers/mtd/nand/atmel/nand-controller.c
@@ -2510,7 +2510,7 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
return nc->caps->ops->remove(nc);
}
-static int atmel_nand_controller_resume(struct device *dev)
+static __maybe_unused int atmel_nand_controller_resume(struct device *dev)
{
struct atmel_nand_controller *nc = dev_get_drvdata(dev);
struct atmel_nand *nand;
--
2.9.0
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-05-31 16:40 +0200 |
| Message-ID | <tNcX0-62R-13@gated-at.bofh.it> |
| In reply to | #1653989 |
On Wed, 31 May 2017 10:19:26 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added suspend/resume support causes a harmless warning:
>
> drivers/mtd/nand/atmel/nand-controller.c:2513:12: error: 'atmel_nand_controller_resume' defined but not used [-Werror=unused-function]
>
> This shuts up the warning with a __maybe_unused annotation.
Applied to nand/next.
Thanks,
Boris
>
> Fixes: b107007a7114 ("mtd: nand: atmel: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mtd/nand/atmel/nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 6055831c953f..d24e67b95167 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -2510,7 +2510,7 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
> return nc->caps->ops->remove(nc);
> }
>
> -static int atmel_nand_controller_resume(struct device *dev)
> +static __maybe_unused int atmel_nand_controller_resume(struct device *dev)
> {
> struct atmel_nand_controller *nc = dev_get_drvdata(dev);
> struct atmel_nand *nand;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web