Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653699 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2017-05-31 01:00 +0200 |
| Last post | 2017-05-31 10:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding Rob Herring <robh@kernel.org> - 2017-05-31 01:00 +0200
Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding Cosar Dindar <cosardindar@gmail.com> - 2017-05-31 10:20 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-05-31 01:00 +0200 |
| Subject | Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding |
| Message-ID | <tMYhj-4Sk-5@gated-at.bofh.it> |
On Sat, May 20, 2017 at 04:32:12PM +0300, Cosar Dindar wrote:
> Add device tree binding for STM32F4.
>
> Signed-off-by: Cosar Dindar <cosardindar@gmail.com>
> ---
> Documentation/devicetree/bindings/crypto/st,stm32-crc.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> index 3ba92a5..7b30f1e 100644
> --- a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> +++ b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> @@ -1,7 +1,7 @@
> * STMicroelectronics STM32 CRC
>
> Required properties:
> -- compatible: Should be "st,stm32f7-crc".
> +- compatible: Can be either "st,stm32f7-crc" or "st,srm32f4-crc".
Here you say either, but the example has both.
> - reg: The address and length of the peripheral registers space
> - clocks: The input clock of the CRC instance
>
> @@ -10,7 +10,7 @@ Optional properties: none
> Example:
>
> crc: crc@40023000 {
> - compatible = "st,stm32f7-crc";
> + compatible = "st,stm32f7-crc", "st,stm32f4-crc";
> reg = <0x40023000 0x400>;
> clocks = <&rcc 0 12>;
> };
> --
> 2.7.4
>
[toc] | [next] | [standalone]
| From | Cosar Dindar <cosardindar@gmail.com> |
|---|---|
| Date | 2017-05-31 10:20 +0200 |
| Message-ID | <tN71g-2f2-35@gated-at.bofh.it> |
| In reply to | #1653699 |
On Tue, May 30, 2017 at 05:50:24PM -0500, Rob Herring wrote:
> On Sat, May 20, 2017 at 04:32:12PM +0300, Cosar Dindar wrote:
> > Add device tree binding for STM32F4.
> >
> > Signed-off-by: Cosar Dindar <cosardindar@gmail.com>
> > ---
> > Documentation/devicetree/bindings/crypto/st,stm32-crc.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> > index 3ba92a5..7b30f1e 100644
> > --- a/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-crc.txt
> > @@ -1,7 +1,7 @@
> > * STMicroelectronics STM32 CRC
> >
> > Required properties:
> > -- compatible: Should be "st,stm32f7-crc".
> > +- compatible: Can be either "st,stm32f7-crc" or "st,srm32f4-crc".
>
> Here you say either, but the example has both.
>
Thanks for reviewing. Here it could be changed as :
Should be one of the following string
"st,stm32f7-crc"
"st,stm32f4-crc"
Also, example may not contain both binding strings, I think. It could be leaved unchanged
as in the previous version. I will make these changes with this way if it is OK.
> > - reg: The address and length of the peripheral registers space
> > - clocks: The input clock of the CRC instance
> >
> > @@ -10,7 +10,7 @@ Optional properties: none
> > Example:
> >
> > crc: crc@40023000 {
> > - compatible = "st,stm32f7-crc";
> > + compatible = "st,stm32f7-crc", "st,stm32f4-crc";
> > reg = <0x40023000 0x400>;
> > clocks = <&rcc 0 12>;
> > };
> > --
> > 2.7.4
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web