Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651116 > unrolled thread

[PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board

Started byEddie Cai <eddie.cai.linux@gmail.com>
First post2017-05-26 09:10 +0200
Last post2017-05-31 04:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-05-26 09:10 +0200
    Re: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly  reload board Robin Murphy <robin.murphy@arm.com> - 2017-05-26 13:40 +0200
      Re: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly  reload board Eddie Cai <eddie.cai.linux@gmail.com> - 2017-05-31 04:30 +0200

#1651116 — [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board

FromEddie Cai <eddie.cai.linux@gmail.com>
Date2017-05-26 09:10 +0200
Subject[PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board
Message-ID<tLhxL-2Oy-1@gated-at.bofh.it>
firefly reload board not support sd card yet. so support it.

Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
---
 arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 31 +++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
index 413b61f..2f41209 100644
--- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
@@ -57,6 +57,17 @@
 		clock-output-names = "ext_gmac";
 	};
 
+	vcc_sd: sdmmc-regulator {
+		compatible = "regulator-fixed";
+		gpio = <&gpio7 RK_PB3 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&sdmmc_pwr>;
+		regulator-name = "vcc_sd";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		startup-delay-us = <100000>;
+		vin-supply = <&vcc_io>;
+	};
 
 	vcc_flash: flash-regulator {
 		compatible = "regulator-fixed";
@@ -281,6 +292,26 @@
 			rockchip,pins = <4 8 RK_FUNC_GPIO &pcfg_output_high>;
 		};
 	};
+
+	sdmmc {
+		sdmmc_pwr: sdmmc-pwr {
+			rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
+&sdmmc {
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	card-detect-delay = <200>;
+	disable-wp;
+	num-slots = <1>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
+	vmmc-supply = <&vcc_sd>;
+	vqmmc-supply = <&vccio_sd>;
+	status = "okay";
 };
 
 &tsadc {
-- 
1.9.1

[toc] | [next] | [standalone]

#1651329 — Re: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board

FromRobin Murphy <robin.murphy@arm.com>
Date2017-05-26 13:40 +0200
SubjectRe: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board
Message-ID<tLlL3-5kc-15@gated-at.bofh.it>
In reply to#1651116
On 26/05/17 08:07, Eddie Cai wrote:
> firefly reload board not support sd card yet. so support it.

I'm confused... According to pictures and the schematic the microSD
socket and vcc_sd supply are on the baseboard, not the core module, and
these nodes already exist in rk3288-firefly-reload.dts :/

Robin.

> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 31 +++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> index 413b61f..2f41209 100644
> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> @@ -57,6 +57,17 @@
>  		clock-output-names = "ext_gmac";
>  	};
>  
> +	vcc_sd: sdmmc-regulator {
> +		compatible = "regulator-fixed";
> +		gpio = <&gpio7 RK_PB3 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&sdmmc_pwr>;
> +		regulator-name = "vcc_sd";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		startup-delay-us = <100000>;
> +		vin-supply = <&vcc_io>;
> +	};
>  
>  	vcc_flash: flash-regulator {
>  		compatible = "regulator-fixed";
> @@ -281,6 +292,26 @@
>  			rockchip,pins = <4 8 RK_FUNC_GPIO &pcfg_output_high>;
>  		};
>  	};
> +
> +	sdmmc {
> +		sdmmc_pwr: sdmmc-pwr {
> +			rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
> +&sdmmc {
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	cap-sd-highspeed;
> +	card-detect-delay = <200>;
> +	disable-wp;
> +	num-slots = <1>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
> +	vmmc-supply = <&vcc_sd>;
> +	vqmmc-supply = <&vccio_sd>;
> +	status = "okay";
>  };
>  
>  &tsadc {
>

[toc] | [prev] | [next] | [standalone]

#1653786 — Re: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board

FromEddie Cai <eddie.cai.linux@gmail.com>
Date2017-05-31 04:30 +0200
SubjectRe: [PATCH V2] ARM: dts: rockchip:add sd card support for firefly reload board
Message-ID<tN1yx-76t-5@gated-at.bofh.it>
In reply to#1651329
2017-05-26 19:31 GMT+08:00 Robin Murphy <robin.murphy@arm.com>:
> On 26/05/17 08:07, Eddie Cai wrote:
>> firefly reload board not support sd card yet. so support it.
>
> I'm confused... According to pictures and the schematic the microSD
> socket and vcc_sd supply are on the baseboard, not the core module, and
> these nodes already exist in rk3288-firefly-reload.dts :/
agree, please ignore this patch
>
> Robin.
>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 31 +++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> index 413b61f..2f41209 100644
>> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
>> @@ -57,6 +57,17 @@
>>               clock-output-names = "ext_gmac";
>>       };
>>
>> +     vcc_sd: sdmmc-regulator {
>> +             compatible = "regulator-fixed";
>> +             gpio = <&gpio7 RK_PB3 GPIO_ACTIVE_LOW>;
>> +             pinctrl-names = "default";
>> +             pinctrl-0 = <&sdmmc_pwr>;
>> +             regulator-name = "vcc_sd";
>> +             regulator-min-microvolt = <3300000>;
>> +             regulator-max-microvolt = <3300000>;
>> +             startup-delay-us = <100000>;
>> +             vin-supply = <&vcc_io>;
>> +     };
>>
>>       vcc_flash: flash-regulator {
>>               compatible = "regulator-fixed";
>> @@ -281,6 +292,26 @@
>>                       rockchip,pins = <4 8 RK_FUNC_GPIO &pcfg_output_high>;
>>               };
>>       };
>> +
>> +     sdmmc {
>> +             sdmmc_pwr: sdmmc-pwr {
>> +                     rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
>> +             };
>> +     };
>> +};
>> +
>> +&sdmmc {
>> +     bus-width = <4>;
>> +     cap-mmc-highspeed;
>> +     cap-sd-highspeed;
>> +     card-detect-delay = <200>;
>> +     disable-wp;
>> +     num-slots = <1>;
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
>> +     vmmc-supply = <&vcc_sd>;
>> +     vqmmc-supply = <&vccio_sd>;
>> +     status = "okay";
>>  };
>>
>>  &tsadc {
>>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web