Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652036 > unrolled thread
| Started by | Noam Camus <noamca@mellanox.com> |
|---|---|
| First post | 2017-05-28 09:00 +0200 |
| Last post | 2017-05-29 17:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Noam Camus <noamca@mellanox.com> - 2017-05-28 09:00 +0200
Re: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-29 17:20 +0200
| From | Noam Camus <noamca@mellanox.com> |
|---|---|
| Date | 2017-05-28 09:00 +0200 |
| Subject | [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug |
| Message-ID | <tM0lc-6QK-9@gated-at.bofh.it> |
From: Noam Camus <noamca@mellanox.com> This counter represents threshold for consecutive stall that which trigger HW threads scheduling. When this feature is enabled low values of this counter cause downgrade in performance and in the worst case even a livelock. Remove those couple of lines and resort to HW reset value i.e. this feature is disabled (.sten field equals 0). Signed-off-by: Noam Camus <noamca@mellanox.com> --- arch/arc/plat-eznps/mtm.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c index aaaaffd..e0cb36b 100644 --- a/arch/arc/plat-eznps/mtm.c +++ b/arch/arc/plat-eznps/mtm.c @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu) mt_ctrl.value = 0; mt_ctrl.hsen = 1; mt_ctrl.hs_cnt = MT_CTRL_HS_CNT; - mt_ctrl.sten = 1; - mt_ctrl.st_cnt = MT_CTRL_ST_CNT; mt_ctrl.mten = 1; write_aux_reg(CTOP_AUX_MT_CTRL, mt_ctrl.value); -- 1.7.1
[toc] | [next] | [standalone]
| From | Alexey Brodkin <Alexey.Brodkin@synopsys.com> |
|---|---|
| Date | 2017-05-29 17:20 +0200 |
| Subject | Re: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug |
| Message-ID | <tMuCB-1GC-7@gated-at.bofh.it> |
| In reply to | #1652036 |
Hi Noam, On Sun, 2017-05-28 at 09:52 +0300, Noam Camus wrote: > From: Noam Camus <noamca@mellanox.com> > > This counter represents threshold for consecutive stall that which > trigger HW threads scheduling. > When this feature is enabled low values of this counter cause > downgrade in performance and in the worst case even a livelock. > > Remove those couple of lines and resort to HW reset value i.e. > this feature is disabled (.sten field equals 0). Looks like you made a change I was asking for here. But there's no mention of the change so it's easy to not note that change. Not critical but please add a changelog next time even if it's only a comment message that was modified since the previous revision. Otherwise... Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com> > Signed-off-by: Noam Camus <noamca@mellanox.com> > --- > arch/arc/plat-eznps/mtm.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c > index aaaaffd..e0cb36b 100644 > --- a/arch/arc/plat-eznps/mtm.c > +++ b/arch/arc/plat-eznps/mtm.c > @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu) > mt_ctrl.value = 0; > mt_ctrl.hsen = 1; > mt_ctrl.hs_cnt = MT_CTRL_HS_CNT; > - mt_ctrl.sten = 1; > - mt_ctrl.st_cnt = MT_CTRL_ST_CNT; > mt_ctrl.mten = 1; > write_aux_reg(CTOP_AUX_MT_CTRL, mt_ctrl.value); >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web