Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1652527 > unrolled thread
| Started by | Murilo Opsfelder Araujo <mopsfelder@gmail.com> |
|---|---|
| First post | 2017-05-29 15:30 +0200 |
| Last post | 2017-05-30 13:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo <mopsfelder@gmail.com> - 2017-05-29 15:30 +0200
Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Guenter Roeck <linux@roeck-us.net> - 2017-05-29 21:10 +0200
Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Michael Ellerman <mpe@ellerman.id.au> - 2017-05-30 13:00 +0200
| From | Murilo Opsfelder Araujo <mopsfelder@gmail.com> |
|---|---|
| Date | 2017-05-29 15:30 +0200 |
| Subject | [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies |
| Message-ID | <tMsU9-s2-5@gated-at.bofh.it> |
drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
setting CONFIG_PPC_RTAS throws the following errors:
ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
CONFIG_PPC_RTAS was not set. Logs are here:
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 8b9049d..e6e31a1 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1688,7 +1688,7 @@ config MEN_A21_WDT
config WATCHDOG_RTAS
tristate "RTAS watchdog"
- depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
+ depends on PPC_RTAS
help
This driver adds watchdog support for the RTAS watchdog.
--
2.9.4
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-05-29 21:10 +0200 |
| Subject | Re: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies |
| Message-ID | <tMydc-4jw-9@gated-at.bofh.it> |
| In reply to | #1652527 |
On 05/29/2017 06:26 AM, Murilo Opsfelder Araujo wrote: > drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c, > which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without > setting CONFIG_PPC_RTAS throws the following errors: > > ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined! > > This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and > CONFIG_PPC_RTAS was not set. Logs are here: > > http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/ > > This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just > CONFIG_PPC_RTAS, removing COMPILE_TEST entirely. > > Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 8b9049d..e6e31a1 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1688,7 +1688,7 @@ config MEN_A21_WDT > > config WATCHDOG_RTAS > tristate "RTAS watchdog" > - depends on PPC_RTAS || (PPC64 && COMPILE_TEST) > + depends on PPC_RTAS > help > This driver adds watchdog support for the RTAS watchdog. > >
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-05-30 13:00 +0200 |
| Message-ID | <tMN2y-6he-15@gated-at.bofh.it> |
| In reply to | #1652527 |
Murilo Opsfelder Araujo <mopsfelder@gmail.com> writes: > drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c, > which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without > setting CONFIG_PPC_RTAS throws the following errors: > > ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined! > ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined! > > This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and > CONFIG_PPC_RTAS was not set. Logs are here: > > http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/ > > This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just > CONFIG_PPC_RTAS, removing COMPILE_TEST entirely. > > Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com> > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web