Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653690 > unrolled thread

[PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering violations

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering violations Logan Gunthorpe <logang@deltatee.com> - 2017-05-31 00:40 +0200
    Re: [PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering  violations Vinod Koul <vinod.koul@intel.com> - 2017-06-01 18:40 +0200

#1653690 — [PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering violations

This dma engine driver directly accesses page_link assuming knowledge
that should be contained only in scatterlist.h.

We replace these with calls to sg_chain and sg_assign_page.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Stephen Bates <sbates@raithlin.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Per Förlin <per.forlin@axis.com>
---

v2: Splits the patch into two: one per driver

 drivers/dma/imx-dma.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index ab0fb804fb1e..f681df8f0ed3 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -888,7 +888,7 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic(
 	sg_init_table(imxdmac->sg_list, periods);

 	for (i = 0; i < periods; i++) {
-		imxdmac->sg_list[i].page_link = 0;
+		sg_assign_page(&imxdmac->sg_list[i], NULL);
 		imxdmac->sg_list[i].offset = 0;
 		imxdmac->sg_list[i].dma_address = dma_addr;
 		sg_dma_len(&imxdmac->sg_list[i]) = period_len;
@@ -896,10 +896,7 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic(
 	}

 	/* close the loop */
-	imxdmac->sg_list[periods].offset = 0;
-	sg_dma_len(&imxdmac->sg_list[periods]) = 0;
-	imxdmac->sg_list[periods].page_link =
-		((unsigned long)imxdmac->sg_list | 0x01) & ~0x02;
+	sg_chain(imxdmac->sg_list, periods + 1, imxdmac->sg_list);

 	desc->type = IMXDMA_DESC_CYCLIC;
 	desc->sg = imxdmac->sg_list;
--
2.11.0

[toc] | [next] | [standalone]

#1655480 — Re: [PATCH v2 1/2] dmaengine: imx-dma: cleanup scatterlist layering violations

On Tue, May 30, 2017 at 04:39:16PM -0600, Logan Gunthorpe wrote:
> This dma engine driver directly accesses page_link assuming knowledge
> that should be contained only in scatterlist.h.
> 
> We replace these with calls to sg_chain and sg_assign_page.


Applied both, thanks

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web