Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651889 > unrolled thread

[PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP

Back to article view | Back to linux.kernel

Contents

  [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Guenter Roeck <linux@roeck-us.net> - 2017-05-27 16:00 +0200
    Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Joel Stanley <joel@jms.id.au> - 2017-05-30 08:20 +0200
      Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Guenter Roeck <linux@roeck-us.net> - 2017-05-31 00:20 +0200

#1651889 — [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP

The driver uses regmap and thus has to select it to avoid build
errors such as the following.

drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
	'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 22d5eafd6815..5ef2814345ef 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -343,6 +343,7 @@ config SENSORS_ASB100
 
 config SENSORS_ASPEED
 	tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+	select REGMAP
 	help
 	  This driver provides support for ASPEED AST2400/AST2500 PWM
 	  and Fan Tacho controllers.
-- 
2.7.4

[toc] | [next] | [standalone]

#1652845

On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> The driver uses regmap and thus has to select it to avoid build
> errors such as the following.
>
> drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
>         'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type

While we're at it the driver should also depend on OF.

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel


> ---
>  drivers/hwmon/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 22d5eafd6815..5ef2814345ef 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -343,6 +343,7 @@ config SENSORS_ASB100
>
>  config SENSORS_ASPEED
>         tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> +       select REGMAP
>         help
>           This driver provides support for ASPEED AST2400/AST2500 PWM
>           and Fan Tacho controllers.
> --
> 2.7.4
>

[toc] | [prev] | [next] | [standalone]

#1653682

On Tue, May 30, 2017 at 03:48:22PM +0930, Joel Stanley wrote:
> On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > The driver uses regmap and thus has to select it to avoid build
> > errors such as the following.
> >
> > drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
> >         'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
> 
> While we're at it the driver should also depend on OF.
> 
The driver compiles without it, so that isn't strictly necessary.

> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Acked-by: Joel Stanley <joel@jms.id.au>
> 
Thanks,

Guenter

> Cheers,
> 
> Joel
> 
> 
> > ---
> >  drivers/hwmon/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 22d5eafd6815..5ef2814345ef 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -343,6 +343,7 @@ config SENSORS_ASB100
> >
> >  config SENSORS_ASPEED
> >         tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> > +       select REGMAP
> >         help
> >           This driver provides support for ASPEED AST2400/AST2500 PWM
> >           and Fan Tacho controllers.
> > --
> > 2.7.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web