Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653236 > unrolled thread

[PATCH] arc: Add "include chroot" for DT bindings

Back to article view | Back to linux.kernel

Contents

  [PATCH] arc: Add "include chroot" for DT bindings Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-30 15:30 +0200
    Re: [PATCH] arc: Add "include chroot" for DT bindings Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-05-30 18:40 +0200
    Re: [PATCH] arc: Add "include chroot" for DT bindings Rob Herring <robh+dt@kernel.org> - 2017-05-30 19:00 +0200
      Re: [PATCH] arc: Add "include chroot" for DT bindings Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-30 19:10 +0200

#1653236 — [PATCH] arc: Add "include chroot" for DT bindings

Basically this extends
c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
ARC where we extensively use Device Tree and there're good reasons
to use DT bindings, especially if those are required.

Otherwise on attempt to compile .dts with something like:
-------------------->8---------------------
 #include <dt-bindings/net/ti-dp83867.h>
-------------------->8---------------------

we inevitably see this compilation failure:
-------------------->8---------------------
arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
 #include <dt-bindings/net/ti-dp83867.h>
                                        ^
compilation terminated.
-------------------->8---------------------

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Rob Herring <robh+dt@kernel.org>
---
 arch/arc/boot/dts/include/dt-bindings | 1 +
 1 file changed, 1 insertion(+)
 create mode 120000 arch/arc/boot/dts/include/dt-bindings

diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
new file mode 120000
index 000000000000..08c00e4972fa
--- /dev/null
+++ b/arch/arc/boot/dts/include/dt-bindings
@@ -0,0 +1 @@
+../../../../../include/dt-bindings
\ No newline at end of file
-- 
2.7.4

[toc] | [next] | [standalone]

#1653371

On 05/30/2017 06:22 AM, Alexey Brodkin wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
> 
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
>   #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
> 
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
>   #include <dt-bindings/net/ti-dp83867.h>
>                                          ^
> compilation terminated.
> -------------------->8---------------------
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
>   arch/arc/boot/dts/include/dt-bindings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 120000 arch/arc/boot/dts/include/dt-bindings
> 
> diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
> new file mode 120000
> index 000000000000..08c00e4972fa
> --- /dev/null
> +++ b/arch/arc/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file


I'm OK with adding this to ARC, but won't it be nicer to have a generic include 
helper instead to avoid boilerplate addition in multiple places ?

-Vineet

[toc] | [prev] | [next] | [standalone]

#1653393

On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
>  #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
>  #include <dt-bindings/net/ti-dp83867.h>
>                                         ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
>  arch/arc/boot/dts/include/dt-bindings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 120000 arch/arc/boot/dts/include/dt-bindings

I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
arch to separate directory") does what you want.

Rob

[toc] | [prev] | [next] | [standalone]

#1653409

Hi Rob,

On Tue, 2017-05-30 at 11:56 -0500, Rob Herring wrote:
> On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > 
> > Basically this extends
> > c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> > ARC where we extensively use Device Tree and there're good reasons
> > to use DT bindings, especially if those are required.
> > 
> > Otherwise on attempt to compile .dts with something like:
> > -------------------->8---------------------
> >  #include <dt-bindings/net/ti-dp83867.h>
> > -------------------->8---------------------
> > 
> > we inevitably see this compilation failure:
> > -------------------->8---------------------
> > arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> >  #include <dt-bindings/net/ti-dp83867.h>
> >                                         ^
> > compilation terminated.
> > -------------------->8---------------------
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> >  arch/arc/boot/dts/include/dt-bindings | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 120000 arch/arc/boot/dts/include/dt-bindings
> 
> I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
> arch to separate directory") does what you want.

Indeed that helps!
Thanks a lot for the pointer!

-Alexey

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web