Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653125 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-05-30 13:20 +0200 |
| Last post | 2017-05-31 02:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] gpio: xra1403: select REGMAP_SPI Arnd Bergmann <arnd@arndb.de> - 2017-05-30 13:20 +0200
RE: [PATCH] gpio: xra1403: select REGMAP_SPI "Han, Nandor (GE Healthcare)" <nandor.han@ge.com> - 2017-05-30 13:50 +0200
Re: [PATCH] gpio: xra1403: select REGMAP_SPI Linus Walleij <linus.walleij@linaro.org> - 2017-05-31 02:20 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-30 13:20 +0200 |
| Subject | [PATCH] gpio: xra1403: select REGMAP_SPI |
| Message-ID | <tMNlU-6D9-27@gated-at.bofh.it> |
Without the regmap code, we get a link error:
drivers/gpio/built-in.o: In function `xra1403_probe':
(.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 66d1f353ca73..238fc231081a 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1241,6 +1241,7 @@ config GPIO_PISOSR
config GPIO_XRA1403
tristate "EXAR XRA1403 16-bit GPIO expander"
+ select REGMAP_SPI
help
GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
--
2.9.0
[toc] | [next] | [standalone]
| From | "Han, Nandor (GE Healthcare)" <nandor.han@ge.com> |
|---|---|
| Date | 2017-05-30 13:50 +0200 |
| Message-ID | <tMNOW-6P4-31@gated-at.bofh.it> |
| In reply to | #1653125 |
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: 30 May 2017 14:13
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: Han, Nandor (GE Healthcare) <nandor.han@ge.com>; Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: EXT: [PATCH] gpio: xra1403: select REGMAP_SPI
>
> Without the regmap code, we get a link error:
>
> drivers/gpio/built-in.o: In function `xra1403_probe':
> (.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
>
> Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nandor Han <nandor.han@ge.com>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 66d1f353ca73..238fc231081a 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1241,6 +1241,7 @@ config GPIO_PISOSR
>
> config GPIO_XRA1403
> tristate "EXAR XRA1403 16-bit GPIO expander"
> + select REGMAP_SPI
> help
> GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
>
> --
> 2.9.0
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-05-31 02:20 +0200 |
| Message-ID | <tMZwJ-5Nj-7@gated-at.bofh.it> |
| In reply to | #1653125 |
On Tue, May 30, 2017 at 1:13 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Without the regmap code, we get a link error:
>
> drivers/gpio/built-in.o: In function `xra1403_probe':
> (.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
>
> Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours,
Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web