Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1653124 > unrolled thread

[PATCH] ASoC: sgtl5000: add avc enable control

Started byRichard Leitner <richard.leitner@skidata.com>
First post2017-05-30 13:20 +0200
Last post2017-05-30 13:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ASoC: sgtl5000: add avc enable control Richard Leitner <richard.leitner@skidata.com> - 2017-05-30 13:20 +0200
    Re: [PATCH] ASoC: sgtl5000: add avc enable control Mark Brown <broonie@kernel.org> - 2017-05-30 13:40 +0200
      Re: [PATCH] ASoC: sgtl5000: add avc enable control Richard Leitner <richard.leitner@skidata.com> - 2017-05-30 13:50 +0200

#1653124 — [PATCH] ASoC: sgtl5000: add avc enable control

FromRichard Leitner <richard.leitner@skidata.com>
Date2017-05-30 13:20 +0200
Subject[PATCH] ASoC: sgtl5000: add avc enable control
Message-ID<tMNlU-6D9-15@gated-at.bofh.it>
This control enables the automatic volume control (AVC) of SGTL5000
using its DAP_AVC_CTRL register.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 sound/soc/codecs/sgtl5000.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 5a2702e..ad8c9a8 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -434,6 +434,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
 			0x1f, 1,
 			lineout_volume),
 	SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
+
+	SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
 };
 
 /* mute the codec used by alsa core */
-- 
2.1.4

[toc] | [next] | [standalone]


#1653138

FromMark Brown <broonie@kernel.org>
Date2017-05-30 13:40 +0200
Message-ID<tMNFf-6JG-7@gated-at.bofh.it>
In reply to#1653124

[Multipart message — attachments visible in raw view] — view raw

On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote:

> +
> +	SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),

All on/off switches should end in Switch as covered in ControlNames.txt.

[toc] | [prev] | [next] | [standalone]


#1653155

FromRichard Leitner <richard.leitner@skidata.com>
Date2017-05-30 13:50 +0200
Message-ID<tMNOW-6P4-13@gated-at.bofh.it>
In reply to#1653138
On 05/30/2017 01:33 PM, Mark Brown wrote:
> On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote:
> 
>> +
>> +	SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
> 
> All on/off switches should end in Switch as covered in ControlNames.txt.

Ok. Sorry & Thanks. I'll send a V2.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web