Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653152 > unrolled thread

[PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

Back to article view | Back to linux.kernel

Contents

  [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-05-30 13:40 +0200
    Re: [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing  and hypercall improvements Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 19:10 +0200
      Re: [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-05-31 16:30 +0200

#1653152 — [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

Changes since v4:
- Get rid of union aliasing in the series [Andy Shevchenko]. We still use
  it a lot across Hyper-V code and we should probably get rid of it
  entirely.
- Code style changes [Andy Shevchenko].
- Use __set_bit(), lower/upper_32_bits where possible [Andy Shevchenko].
- Use 'A' double register in 32 bit hypercalls implementation
  [Jork Loeser].

Changes are also noted in individual patches.

K. Y., while all the changes are not groundbreaking I still have to drop
'Tested-by' tags on affected patches. It would be great to have this
series retested.

Thomas, Ingo, Peter, would you like to take this through x86 tree or should
we push it through Greg's char-misc tree?

Original description:

Hyper-V supports hypercalls for doing local and remote TLB flushing and
gives its guests hints when using hypercall is preferred. While doing
hypercalls for local TLB flushes is probably not practical (and is not
being suggested by modern Hyper-V versions) remote TLB flush with a
hypercall brings significant improvement.

To test the series I wrote a special 'TLB trasher': on a 16 vCPU guest I
was creating 32 threads which were doing 100000 mmap/munmaps each on some
big file. Here are the results:

Before:
# time ./pthread_mmap ./randfile 
real	3m33.118s
user	0m3.698s
sys	3m16.624s

After:
# time ./pthread_mmap ./randfile 
real	2m19.920s
user	0m2.662s
sys	2m9.948s

This series brings a number of small improvements along the way: fast
hypercall implementation and using it for event signaling, rep hypercalls
implementation, hyperv tracing subsystem (which only traces the newly added
remote TLB flush for now).

Vitaly Kuznetsov (10):
  x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
  x86/hyper-v: stash the max number of virtual/logical processor
  x86/hyper-v: make hv_do_hypercall() inline
  x86/hyper-v: fast hypercall implementation
  hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT
  x86/hyper-v: implement rep hypercalls
  hyper-v: globalize vp_index
  x86/hyper-v: use hypercall for remote TLB flush
  x86/hyper-v: support extended CPU ranges for TLB flush hypercalls
  tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

 MAINTAINERS                         |   1 +
 arch/x86/Kbuild                     |   4 +-
 arch/x86/hyperv/Makefile            |   2 +-
 arch/x86/hyperv/hv_init.c           |  90 ++++++------
 arch/x86/hyperv/mmu.c               | 275 ++++++++++++++++++++++++++++++++++++
 arch/x86/include/asm/mshyperv.h     | 148 ++++++++++++++++++-
 arch/x86/include/asm/trace/hyperv.h |  34 +++++
 arch/x86/include/uapi/asm/hyperv.h  |  17 +++
 arch/x86/kernel/cpu/mshyperv.c      |  13 +-
 drivers/hv/channel_mgmt.c           |  20 +--
 drivers/hv/connection.c             |   7 +-
 drivers/hv/hv.c                     |   9 --
 drivers/hv/hyperv_vmbus.h           |  11 --
 drivers/hv/vmbus_drv.c              |  17 ---
 drivers/pci/host/pci-hyperv.c       |   4 +-
 include/linux/hyperv.h              |  17 +--
 16 files changed, 541 insertions(+), 128 deletions(-)
 create mode 100644 arch/x86/hyperv/mmu.c
 create mode 100644 arch/x86/include/asm/trace/hyperv.h

-- 
2.9.4

[toc] | [next] | [standalone]

#1653401 — Re: [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> K. Y., while all the changes are not groundbreaking I still have to drop
> 'Tested-by' tags on affected patches. It would be great to have this
> series retested.
>
> Thomas, Ingo, Peter, would you like to take this through x86 tree or should
> we push it through Greg's char-misc tree?

What does MAINTAINERS tell about?

> Vitaly Kuznetsov (10):

I have found number of small issues, after addressing them, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1654310

Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> K. Y., while all the changes are not groundbreaking I still have to drop
>> 'Tested-by' tags on affected patches. It would be great to have this
>> series retested.
>>
>> Thomas, Ingo, Peter, would you like to take this through x86 tree or should
>> we push it through Greg's char-misc tree?
>
> What does MAINTAINERS tell about?
>

MAINTAINERS says Hyper-V:

Hyper-V CORE AND DRIVERS
M:      "K. Y. Srinivasan" <kys@microsoft.com>
M:      Haiyang Zhang <haiyangz@microsoft.com>
M:      Stephen Hemminger <sthemmin@microsoft.com>
L:      devel@linuxdriverproject.org
S:      Maintained
F:      arch/x86/include/asm/mshyperv.h
F:      arch/x86/include/uapi/asm/hyperv.h
F:      arch/x86/kernel/cpu/mshyperv.c
F:      arch/x86/hyperv
...

But Andy L. was asking if we could push this through x86 as it clashes
with his PCID series.

>> Vitaly Kuznetsov (10):
>
> I have found number of small issues, after addressing them, FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Thanks for the review!

-- 
  Vitaly

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web