Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653048 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-30 11:50 +0200 |
| Last post | 2017-05-30 13:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] gpiolib: remove unused variable 'i' Colin King <colin.king@canonical.com> - 2017-05-30 11:50 +0200
Re: [PATCH] gpiolib: remove unused variable 'i' Mark Brown <broonie@kernel.org> - 2017-05-30 13:00 +0200
Re: [PATCH] gpiolib: remove unused variable 'i' Colin Ian King <colin.king@canonical.com> - 2017-05-30 13:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-30 11:50 +0200 |
| Subject | [PATCH] gpiolib: remove unused variable 'i' |
| Message-ID | <tMLWO-5BU-25@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Fixes smatch warning: unused variable 'i' [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpiolib.c | 2 --
sound/soc/generic/audio-graph-scu-card.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
{
- int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c
index c5c52d1f500c..e15f63c74f59 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -246,7 +246,7 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv)
continue;
if (rcpu_ep != cpu_ep) {
- dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",
+ dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n",
cpu_ep->name, codec_ep->name, rcpu_ep->name);
ret = -EINVAL;
goto parse_of_err;
--
2.11.0
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-05-30 13:00 +0200 |
| Message-ID | <tMN2x-6he-9@gated-at.bofh.it> |
| In reply to | #1653048 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Fixes smatch warning: unused variable 'i' [-Wunused-variable] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpio/gpiolib.c | 2 -- > sound/soc/generic/audio-graph-scu-card.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) You've got two unrelated patches in one here (as a quick review of your CC list would probably have warned you...).
[toc] | [prev] | [next] | [standalone]
| From | Colin Ian King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-30 13:10 +0200 |
| Message-ID | <tMNcd-6zF-3@gated-at.bofh.it> |
| In reply to | #1653114 |
[Multipart message — attachments visible in raw view] — view raw
On 30/05/17 11:58, Mark Brown wrote: > On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Fixes smatch warning: unused variable 'i' [-Wunused-variable] >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/gpio/gpiolib.c | 2 -- >> sound/soc/generic/audio-graph-scu-card.c | 2 +- >> 2 files changed, 1 insertion(+), 3 deletions(-) > > You've got two unrelated patches in one here (as a quick review of your > CC list would probably have warned you...). > Oops, my bad. V2 resent.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web