Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1653061 > unrolled thread

Re: [PATCH v4 1/2] clk: at91: fix clk-generated parenting

Started byAlexandre Belloni <alexandre.belloni@free-electrons.com>
First post2017-05-30 12:00 +0200
Last post2017-06-01 09:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 1/2] clk: at91: fix clk-generated parenting Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-30 12:00 +0200
    Re: [PATCH v4 1/2] clk: at91: fix clk-generated parenting Stephen Boyd <sboyd@codeaurora.org> - 2017-06-01 09:50 +0200

#1653061 — Re: [PATCH v4 1/2] clk: at91: fix clk-generated parenting

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-05-30 12:00 +0200
SubjectRe: [PATCH v4 1/2] clk: at91: fix clk-generated parenting
Message-ID<tMM6v-5FJ-29@gated-at.bofh.it>
On 18/05/2017 at 18:33:02 -0700, Stephen Boyd wrote:
> On 05/12, Alexandre Belloni wrote:
> > clk_generated_startup is called after clk_hw_register. So the first call to
> > get_parent will not have the correct value (i.e. 0) and because this is
> > cached, it may never be updated.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> 
> Fixes tag?

Yep,

Fixes: df70aeef6083 ("clk: at91: add generated clock driver")

Can you add it or do you want a new version?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [next] | [standalone]


#1654894

FromStephen Boyd <sboyd@codeaurora.org>
Date2017-06-01 09:50 +0200
Message-ID<tNt1M-86d-35@gated-at.bofh.it>
In reply to#1653061
On 05/30, Alexandre Belloni wrote:
> On 18/05/2017 at 18:33:02 -0700, Stephen Boyd wrote:
> > On 05/12, Alexandre Belloni wrote:
> > > clk_generated_startup is called after clk_hw_register. So the first call to
> > > get_parent will not have the correct value (i.e. 0) and because this is
> > > cached, it may never be updated.
> > > 
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > 
> > Fixes tag?
> 
> Yep,
> 
> Fixes: df70aeef6083 ("clk: at91: add generated clock driver")
> 
> Can you add it or do you want a new version?
> 

I'll take care of it now and apply it to clk-next. The second
patch can go in after comments are addressed.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web