Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1652849 > unrolled thread

[PATCH V2 00/27] Drivers: ccree - align block comments

Started byDerek Robson <robsonde@gmail.com>
First post2017-05-30 08:20 +0200
Last post2017-06-03 16:10 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH V2 00/27] Drivers: ccree - align block comments Derek Robson <robsonde@gmail.com> - 2017-05-30 08:20 +0200
    Re: [PATCH V2 00/27] Drivers: ccree - align block comments Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-05-30 09:00 +0200
      Re: [PATCH V2 00/27] Drivers: ccree - align block comments "Tobin C. Harding" <me@tobin.cc> - 2017-05-31 00:00 +0200
    Re: [PATCH V2 00/27] Drivers: ccree - align block comments Greg KH <gregkh@linuxfoundation.org> - 2017-06-03 16:10 +0200

#1652849 — [PATCH V2 00/27] Drivers: ccree - align block comments

FromDerek Robson <robsonde@gmail.com>
Date2017-05-30 08:20 +0200
Subject[PATCH V2 00/27] Drivers: ccree - align block comments
Message-ID<tMIFB-3sh-55@gated-at.bofh.it>
Fixed block comments across whole ccree driver

Version #1 has some trailing white space issue in a few patches


Derek Robson (27):
  Drivers: ccree: ssi_sysfs.h - align block comments
  Drivers: ccree: ssi_sysfs.c - align block comments
  Drivers: ccree: ssi_request_mgr.h - align block comments
  Drivers: ccree: ssi_request_mgr.c - align block comments
  Drivers: ccree: ssi_pm_ext.h - align block comments
  Drivers: ccree: ssi_pm_ext.c - align block comments
  Drivers: ccree: ssi_pm.h - align block comments
  Drivers: ccree: ssi_ivgen.c - align block comments
  Drivers: ccree: ssi_hash.h - align block comments
  Drivers: ccree: ssi_hash.c - align block comments
  Drivers: ccree: ssi_fips_local.c - align block comments
  Drivers: ccree: ssi_fips_ll.c - align block comments
  Drivers: ccree: ssi_fips_ext.c - align block comments
  Drivers: ccree: ssi_fips_data.h - align block comments
  Drivers: ccree: ssi_fips.h - align block comments
  Drivers: ccree: ssi_fips.c - align block comments
  Drivers: ccree: ssi_driver.h - align block comments
  Drivers: ccree: ssi_config.h - align block comments
  Drivers: ccree: ssi_cipher.h - align block comments
  Drivers: ccree: ssi_buffer_mgr.h - align block comments
  Drivers: ccree: ssi_buffer_mgr.c - align block comments
  Drivers: ccree: ssi_aead.h - align block comments
  Drivers: ccree: ssi_aead.c - align block comments
  Drivers: ccree: hash_defs.h - align block comments
  Drivers: ccree: cc_regs.h - align block comments
  Drivers: ccree: cc_hw_queue_defs.h - align block comments
  Drivers: ccree: cc_crypto_ctx.h - align block comments

 drivers/staging/ccree/cc_crypto_ctx.h    | 17 +++---
 drivers/staging/ccree/cc_hw_queue_defs.h | 32 +++++------
 drivers/staging/ccree/cc_regs.h          | 13 ++---
 drivers/staging/ccree/hash_defs.h        | 15 +++---
 drivers/staging/ccree/ssi_aead.c         | 45 ++++++++++------
 drivers/staging/ccree/ssi_aead.h         |  7 +--
 drivers/staging/ccree/ssi_buffer_mgr.c   | 87 +++++++++++++++++-------------
 drivers/staging/ccree/ssi_buffer_mgr.h   |  2 +-
 drivers/staging/ccree/ssi_cipher.h       |  2 +-
 drivers/staging/ccree/ssi_config.h       |  5 +-
 drivers/staging/ccree/ssi_driver.h       | 16 +++---
 drivers/staging/ccree/ssi_fips.c         | 16 +++---
 drivers/staging/ccree/ssi_fips.h         |  6 +--
 drivers/staging/ccree/ssi_fips_data.h    | 93 ++++++++++++++++----------------
 drivers/staging/ccree/ssi_fips_ext.c     | 46 ++++++++--------
 drivers/staging/ccree/ssi_fips_ll.c      | 21 ++++----
 drivers/staging/ccree/ssi_fips_local.c   | 21 ++++----
 drivers/staging/ccree/ssi_hash.c         |  9 ++--
 drivers/staging/ccree/ssi_hash.h         |  2 +-
 drivers/staging/ccree/ssi_ivgen.c        |  6 ++-
 drivers/staging/ccree/ssi_pm.h           |  2 +-
 drivers/staging/ccree/ssi_pm_ext.c       | 14 ++---
 drivers/staging/ccree/ssi_pm_ext.h       |  2 +-
 drivers/staging/ccree/ssi_request_mgr.c  | 37 +++++++------
 drivers/staging/ccree/ssi_request_mgr.h  |  2 +-
 drivers/staging/ccree/ssi_sysfs.c        |  3 +-
 drivers/staging/ccree/ssi_sysfs.h        |  2 +-
 27 files changed, 288 insertions(+), 235 deletions(-)

-- 
2.13.0

[toc] | [next] | [standalone]


#1652870

FromAntoine Tenart <antoine.tenart@free-electrons.com>
Date2017-05-30 09:00 +0200
Message-ID<tMJih-3J1-11@gated-at.bofh.it>
In reply to#1652849

[Multipart message — attachments visible in raw view] — view raw

Hello Derek,

On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote:
> Fixed block comments across whole ccree driver

Since all these commits are doing the same logical change across a
single driver, you could probably squash them all into a single one.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1653640

From"Tobin C. Harding" <me@tobin.cc>
Date2017-05-31 00:00 +0200
Message-ID<tMXli-4i6-77@gated-at.bofh.it>
In reply to#1652870
On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote:
> Hello Derek,
> 
> On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote:
> > Fixed block comments across whole ccree driver
> 
> Since all these commits are doing the same logical change across a
> single driver, you could probably squash them all into a single one.

I suggested that when v1 was submitted ;)

> 
> Thanks!
> Antoine

thanks,
Tobin.

[toc] | [prev] | [next] | [standalone]


#1656815

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-03 16:10 +0200
Message-ID<tOhUB-81i-19@gated-at.bofh.it>
In reply to#1652849
On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote:
> Fixed block comments across whole ccree driver
> 
> Version #1 has some trailing white space issue in a few patches

Some of these applied, some did not :(

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web