Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1652742 > unrolled thread

Re: [PATCH] lpfc: nvmet_fc: fix format string

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] lpfc: nvmet_fc: fix format string James Smart <james.smart@broadcom.com> - 2017-05-30 01:10 +0200

#1652742 — Re: [PATCH] lpfc: nvmet_fc: fix format string

Patch is fine.

Signed-off-by: James Smart <james.smart@broadcom.com>

-- james


On 5/19/2017 1:04 AM, Arnd Bergmann wrote:
> The lpfc_nvmeio_data() tracing helper always takes a format string and
> three additional arguments. The latest caller has a format string with
> only two integer arguments, causing this harmless warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c: In function 'lpfc_nvmet_xmt_fcp_release':
> drivers/scsi/lpfc/lpfc_nvmet.c:802:25: error: too many arguments for format [-Werror=format-extra-args]
>    lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d\n", ctxp->oxid,
>
> We could add a dummy argument here, but it seems reasonable to print
> the 'abort' flag as the third argument.
>
> Fixes: 19b58d9473e8 ("nvmet_fc: add req_release to lldd api")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web