Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651705 > unrolled thread

Re: [PATCH] x86/timers: Move simple_udelay_calibration past init_hypervisor_platform

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] x86/timers: Move simple_udelay_calibration past init_hypervisor_platform Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-27 03:40 +0200
    Re: [PATCH] x86/timers: Move simple_udelay_calibration past  init_hypervisor_platform Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-28 18:50 +0200

#1651705 — Re: [PATCH] x86/timers: Move simple_udelay_calibration past init_hypervisor_platform

+Cc Mathias

On Wed, May 24, 2017 at 9:04 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This ensures that adjustments to x86_platform done by the hypervisor
> setup is already respected by this simple calibration.
>
> The current user of this, introduced by 1b5aeebf3a92 ("x86/earlyprintk:
> Add support for earlyprintk via USB3 debug port"), comes much later
> into play.
>

Can you elaborate a bit what is the issue you are experience?

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/x86/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 0b4d3c686b1e..f81823695014 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -980,8 +980,6 @@ void __init setup_arch(char **cmdline_p)
>          */
>         x86_configure_nx();
>
> -       simple_udelay_calibration();
> -
>         parse_early_param();
>
>  #ifdef CONFIG_MEMORY_HOTPLUG
> @@ -1041,6 +1039,8 @@ void __init setup_arch(char **cmdline_p)
>          */
>         init_hypervisor_platform();
>
> +       simple_udelay_calibration();
> +
>         x86_init.resources.probe_roms();
>
>         /* after parse_early_param, so could debug it */



-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1652174 — Re: [PATCH] x86/timers: Move simple_udelay_calibration past init_hypervisor_platform

On 2017-05-27 01:04, Andy Shevchenko wrote:
> +Cc Mathias
> 
> On Wed, May 24, 2017 at 9:04 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> This ensures that adjustments to x86_platform done by the hypervisor
>> setup is already respected by this simple calibration.
>>
>> The current user of this, introduced by 1b5aeebf3a92 ("x86/earlyprintk:
>> Add support for earlyprintk via USB3 debug port"), comes much later
>> into play.
>>
> 
> Can you elaborate a bit what is the issue you are experience?

I stumbled over this while rebasing the patches to boot Linux over the
Jailhouse hypervisor (as non-root cell). Those come with hypervisor
setup code that changes relevant callbacks because Jailhouse does not
virtualize most of the platform devices and simply denies access.

While these patches are still out-of-tree (will propose later this
year), the issue seen here is conceptual: e.g., calibration is pointless
if the hypervisor has a PV channel to report the required parameters -
like vmware.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web