Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1651298 > unrolled thread

[PATCH] platform/x86: intel_cht_int33fe: Set supplied-from property on max17047 dev

Back to article view | Back to linux.kernel

Contents

  [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from property on max17047 dev Hans de Goede <hdegoede@redhat.com> - 2017-05-26 13:00 +0200
    Re: [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from  property on max17047 dev Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 15:30 +0200

#1651298 — [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from property on max17047 dev

Devices with the intel_cht_int33fe ACPI device use a max17047 fuel-gauge
combined with a bq24272i charger, in order for the fuel-gauge driver to
correctly display charging / discharging status it needs to know which
charger is supplying the battery.

This commit sets the supplied-from device property to the name of the
bq24272i charger for this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/intel_cht_int33fe.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
index 6a1b2ca5b6fe..da706e2c4232 100644
--- a/drivers/platform/x86/intel_cht_int33fe.c
+++ b/drivers/platform/x86/intel_cht_int33fe.c
@@ -34,6 +34,13 @@ struct cht_int33fe_data {
 	struct i2c_client *pi3usb30532;
 };
 
+static const char * const max17047_suppliers[] = { "bq24190-charger" };
+
+static const struct property_entry max17047_props[] = {
+	PROPERTY_ENTRY_STRING_ARRAY("supplied-from", max17047_suppliers),
+	{ }
+};
+
 static int cht_int33fe_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
@@ -70,6 +77,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
 
 	memset(&board_info, 0, sizeof(board_info));
 	strlcpy(board_info.type, "max17047", I2C_NAME_SIZE);
+	board_info.properties = max17047_props;
 
 	data->max17047 = i2c_acpi_new_device(dev, 1, &board_info);
 	if (!data->max17047)
-- 
2.13.0

[toc] | [next] | [standalone]

#1653239 — Re: [PATCH] platform/x86: intel_cht_int33fe: Set supplied-from property on max17047 dev

On Fri, May 26, 2017 at 1:53 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Devices with the intel_cht_int33fe ACPI device use a max17047 fuel-gauge
> combined with a bq24272i charger, in order for the fuel-gauge driver to
> correctly display charging / discharging status it needs to know which
> charger is supplying the battery.
>
> This commit sets the supplied-from device property to the name of the
> bq24272i charger for this.

Pushed to testing, thanks!

>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/intel_cht_int33fe.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
> index 6a1b2ca5b6fe..da706e2c4232 100644
> --- a/drivers/platform/x86/intel_cht_int33fe.c
> +++ b/drivers/platform/x86/intel_cht_int33fe.c
> @@ -34,6 +34,13 @@ struct cht_int33fe_data {
>         struct i2c_client *pi3usb30532;
>  };
>
> +static const char * const max17047_suppliers[] = { "bq24190-charger" };
> +
> +static const struct property_entry max17047_props[] = {
> +       PROPERTY_ENTRY_STRING_ARRAY("supplied-from", max17047_suppliers),
> +       { }
> +};
> +
>  static int cht_int33fe_probe(struct i2c_client *client)
>  {
>         struct device *dev = &client->dev;
> @@ -70,6 +77,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
>
>         memset(&board_info, 0, sizeof(board_info));
>         strlcpy(board_info.type, "max17047", I2C_NAME_SIZE);
> +       board_info.properties = max17047_props;
>
>         data->max17047 = i2c_acpi_new_device(dev, 1, &board_info);
>         if (!data->max17047)
> --
> 2.13.0
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web