Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650448 > unrolled thread

Re: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node Rob Herring <robh@kernel.org> - 2017-05-25 14:40 +0200
    答复: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node songxiaowei <songxiaowei@hisilicon.com> - 2017-05-26 03:50 +0200

#1650448 — Re: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node

On Tue, May 23, 2017 at 8:39 PM, songxiaowei <songxiaowei@hisilicon.com> wrote:
> -----邮件原件-----
> 发件人: Rob Herring [mailto:robh@kernel.org]
> 发送时间: 2017年5月23日 22:17
> 收件人: songxiaowei
> 抄送: Wangzhou (B); Gabriele Paoloni; bhelgaas@google.com; mark.rutland@arm.com; xuwei (O); catalin.marinas@arm.com; will.deacon@arm.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Chenfeng (puck); guodong.xu@linaro.org; Wangbinghui; Suzhuangluan
> 主题: Re: [Patch v3 1/3] arm64: dts: hi3660: add pcie node
>
> On Thu, May 18, 2017 at 03:49:46PM +0800, Song Xiaowei wrote:
>> Add PCIe node for hi3660, and add binding documentation.
>>
>> Cc: Guodong Xu <guodong.xu@linaro.org>
>> Signed-off-by: Song Xiaowei <songxiaowei@hisilicon.com>
>> ---
>>  .../devicetree/bindings/pci/hisilicon-pcie.txt     | 52 ++++++++++++++++++++++
>>  arch/arm64/boot/dts/hisilicon/hi3660.dtsi          | 31 +++++++++++++

[...]

>> +  "config": PCIe configuration space registers.
>> +- reset-gpio: perst assert/deassert gpio
>
> reset-gpios
> [songxiaowei] rest-gpio is used to signal 'pcie perst': high level refers to deassert
>              and low level refers to assert. So, I think ' reset-gpio: creates perst assert/deassert signal '
>                         would be a better choice.

What I was saying is the name should be reset-gpios, not reset-gpio.

Rob

[toc] | [next] | [standalone]

#1651025 — 答复: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node

-----邮件原件-----
发件人: Rob Herring [mailto:robh@kernel.org] 
发送时间: 2017年5月25日 20:39
收件人: songxiaowei
抄送: Wangzhou (B); Gabriele Paoloni; bhelgaas@google.com; mark.rutland@arm.com; xuwei (O); catalin.marinas@arm.com; will.deacon@arm.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Chenfeng (puck); guodong.xu@linaro.org; Wangbinghui; Suzhuangluan
主题: Re: 答复: [Patch v3 1/3] arm64: dts: hi3660: add pcie node

On Tue, May 23, 2017 at 8:39 PM, songxiaowei <songxiaowei@hisilicon.com> wrote:
> -----邮件原件-----
> 发件人: Rob Herring [mailto:robh@kernel.org]
> 发送时间: 2017年5月23日 22:17
> 收件人: songxiaowei
> 抄送: Wangzhou (B); Gabriele Paoloni; bhelgaas@google.com; mark.rutland@arm.com; xuwei (O); catalin.marinas@arm.com; will.deacon@arm.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Chenfeng (puck); guodong.xu@linaro.org; Wangbinghui; Suzhuangluan
> 主题: Re: [Patch v3 1/3] arm64: dts: hi3660: add pcie node
>
> On Thu, May 18, 2017 at 03:49:46PM +0800, Song Xiaowei wrote:
>> Add PCIe node for hi3660, and add binding documentation.
>>
>> Cc: Guodong Xu <guodong.xu@linaro.org>
>> Signed-off-by: Song Xiaowei <songxiaowei@hisilicon.com>
>> ---
>>  .../devicetree/bindings/pci/hisilicon-pcie.txt     | 52 ++++++++++++++++++++++
>>  arch/arm64/boot/dts/hisilicon/hi3660.dtsi          | 31 +++++++++++++

[...]

>> +  "config": PCIe configuration space registers.
>> +- reset-gpio: perst assert/deassert gpio
>
> reset-gpios
> [songxiaowei] rest-gpio is used to signal 'pcie perst': high level refers to deassert
>              and low level refers to assert. So, I think ' reset-gpio: creates perst assert/deassert signal '
>                         would be a better choice.

What I was saying is the name should be reset-gpios, not reset-gpio.

[songxiaowei] Ok, I'll fix it. In fact, perst signal only use one line, so reset-gpios contains only one gpio.
Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web